Re: [PATCH v3 2/3] x86/svm: Drop the suffix _guest from vmcb bit

From: Vaishali Thakkar <vaishali.thakkar@vates.tech>
To: Jan Beulich <jbeulich@suse.com>
Cc: andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 2/3] x86/svm: Drop the suffix _guest from vmcb bit
Date: Mon, 18 Mar 2024 08:04:35 +0000	[thread overview]
Message-ID: <eebb0fb3-4ad2-429a-9200-81ad7b3fc0ab@vates.tech> (raw)
In-Reply-To: <3f8af14a-391b-46db-99cb-d7cafe126cfd@suse.com>

On 3/14/24 17:04, Jan Beulich wrote:
> On 13.03.2024 17:41, Vaishali Thakkar wrote:
>> The suffix _guest is redundant for asid bit. Drop it
>> to avoid adding extra code volume.
>>
>> While we're here, replace 0/1 with false/true and use
>> VMCB accessors instead of open coding.
>>
>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Vaishali Thakkar <vaishali.thakkar@vates.tech>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> with ...
> 
>> --- a/xen/arch/x86/hvm/svm/asid.c
>> +++ b/xen/arch/x86/hvm/svm/asid.c
>> @@ -37,14 +37,14 @@ void svm_asid_handle_vmrun(void)
>>       /* ASID 0 indicates that ASIDs are disabled. */
>>       if ( p_asid->asid == 0 )
>>       {
>> -        vmcb_set_guest_asid(vmcb, 1);
>> +        vmcb_set_asid(vmcb,true);
> 
> ... the blank put back that was lost here (can be done while committing).

Thanks

> Jan