From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Stephen Boyd <swboyd@chromium.org>, <freedreno@lists.freedesktop.org>
Cc: dri-devel@lists.freedesktop.org, quic_khsieh@quicinc.com,
seanpaul@chromium.org, dmitry.baryshkov@linaro.org,
quic_jesszhan@quicinc.com, quic_aravindh@quicinc.com
Subject: Re: [Freedreno] [PATCH v2] drm/msm/dpu: handle pm_runtime_get_sync() errors in bind path
Date: Wed, 18 May 2022 18:26:53 -0700 [thread overview]
Message-ID: <ef406fb0-f83e-81ef-071c-d92f7c16c1dd@quicinc.com> (raw)
In-Reply-To: <CAE-0n53Cffs82nQC3_2QADbvQm0f_7tX+NPac8rvJULYE10GvA@mail.gmail.com>
On 5/18/2022 5:40 PM, Stephen Boyd wrote:
> Quoting Abhinav Kumar (2022-05-18 15:34:07)
>> If there are errors while trying to enable the pm in the
>> bind path, it will lead to unclocked access of hw revision
>> register thereby crashing the device.
>>
>> This will not address why the pm_runtime_get_sync() fails
>> but at the very least we should be able to prevent the
>> crash by handling the error and bailing out earlier.
>>
>> changes in v2:
>> - use pm_runtime_resume_and_get() instead of
>> pm_runtime_get_sync()
>>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>> ---
>
> Any Fixes tag? When did pm errors start happening in the bind path?
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
This error got exposed with PANEL_EDP=m and DRM_MSM=y. We were not
testing this combination previously. This combination causes "clk stuck
at OFF" from the pm_runtime_get_sync() path which means we shouldnt
proceed with the next register access since it failed.
We are still debugging the root-cause of why "clk stuck at OFF" error is
present, this is just resolving the crash.
Fixes : 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
prev parent reply other threads:[~2022-05-19 1:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 22:34 [PATCH v2] drm/msm/dpu: handle pm_runtime_get_sync() errors in bind path Abhinav Kumar
2022-05-19 0:31 ` Rob Clark
2022-05-19 0:40 ` Stephen Boyd
2022-05-19 1:26 ` Abhinav Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef406fb0-f83e-81ef-071c-d92f7c16c1dd@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=quic_aravindh@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.