Re: [PATCH v6 00/15] block: cleanup backing and file handling

From: Hanna Reitz <hreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
	qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com
Subject: Re: [PATCH v6 00/15] block: cleanup backing and file handling
Date: Thu, 30 Jun 2022 15:18:31 +0200	[thread overview]
Message-ID: <ef7a6772-6e66-2292-0172-44e212a15100@redhat.com> (raw)
In-Reply-To: <20220624212830.316919-1-vsementsov@yandex-team.ru>

On 24.06.22 23:28, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> That's the first part of
> "[PATCH v5 00/45] Transactional block-graph modifying API",
> updated and almost reviewed.
>
> On commit (15) is added to original scope of
> "block: cleanup backing and file handling", as it's related.
>
> 01: add Hanna's r-b
> 02: - mention snapshot-access in commit msg
>      - return ret in compress_open instead of EINVAL
>      - add Hanna's r-b
> 03: add Hanna's r-b
> 04: - add case in commit msg
>      - fix comments
> 05: - fix type in commit msg
>      - add Hanna's r-b
> 06: add Hanna's r-b
> 07: wording improvements
> 08: - fix wording
>      - add Hanna's r-b
>
> 09: I add the description, whey we allow a degradation. Still,
>      up to maintainers: it's OK to merge 09-13 into one bit commit
>
> 13: - fix s/|/||/
>      - improve comment
>      - more readable logic when handle filters in bdrv_child_cb_attach()
>      - don't keep **child indirection, move to just returning a child ptr
>        (honestly, I didn't analyze all the callers do they need this int value. Do you think it's needed?)
>      - handle snapshot-access.c
> 14: get rid of _ptr
> 15: update comment

Reviewed-by: Hanna Reitz <hreitz@redhat.com>

Patch 2 needs to be rebased on 79ef0cebb5694411e7452f0cf15c4bd170c7f2d6, 
but that should be straightforward.