From: Yinbo Zhu <zhuyinbo@loongson.cn>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: zhanghongchen <zhanghongchen@loongson.cn>,
Liu Peibao <liupeibao@loongson.cn>,
zhuyinbo@loongson.cn
Subject: Re: [PATCH v10 1/2] thermal: loongson-2: add thermal management support
Date: Fri, 11 Nov 2022 18:05:34 +0800 [thread overview]
Message-ID: <ef7a6f77-9f18-e68d-a6a7-61186346c768@loongson.cn> (raw)
In-Reply-To: <d975ae16-58b8-a844-7ffd-7fa06159311c@wanadoo.fr>
在 2022/11/10 下午2:01, Christophe JAILLET 写道:
> Le 09/11/2022 à 09:09, Yinbo Zhu a écrit :
>> Hi Rafael J.Wysocki,
>>
>> I just have a verified on your tree about my patch again, it is okay,
>> if no other proplems, please help merge it to your tree and sync it to
>> linux mainline tree.
>>
>> Thanks,
>> Yinbo.
>>
>
> Hi,
>
> I've sent a few nits on v10, that you are obviously free to take into
> account or not.
>
> However, one of these comments is about thermal_add_hwmon_sysfs() vs
> devm_thermal_add_hwmon_sysfs() in loongson2_thermal_probe().
>
> IMHO, if I'm correct, at least this comment should be fixed.
Hi Christophe JAILLET,
Thanks your addvice, I had send v11 that following your advice,
but some it is different. e.g. devm_request_threaded_irq return value
is integer and use IS_ERR(integer) that isn't appropriate.
Tks,
Yinbo
>
> CJ
next prev parent reply other threads:[~2022-11-11 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 8:34 [PATCH v10 1/2] thermal: loongson-2: add thermal management support Yinbo Zhu
2022-11-03 8:34 ` [PATCH v10 2/2] dt-bindings: thermal: add loongson-2 thermal Yinbo Zhu
2022-11-09 8:12 ` Yinbo Zhu
2022-11-03 9:25 ` [PATCH v10 1/2] thermal: loongson-2: add thermal management support Christophe JAILLET
2022-11-09 8:09 ` Yinbo Zhu
2022-11-10 6:01 ` Christophe JAILLET
2022-11-11 10:05 ` Yinbo Zhu [this message]
2022-11-11 11:19 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef7a6f77-9f18-e68d-a6a7-61186346c768@loongson.cn \
--to=zhuyinbo@loongson.cn \
--cc=amitk@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=zhanghongchen@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.