Re: [PATCH 1/2] usb: xhci: refactor quirks and plat private data

From: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
To: Stephen Boyd <swboyd@chromium.org>,
	Aswath Govindraju <a-govindraju@ti.com>,
	Doug Anderson <dianders@chromium.org>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Mathias Nyman" <mathias.nyman@intel.com>,
	Matthias Kaehlcke <mka@chromium.org>,
	Pawel Laszczak <pawell@cadence.com>,
	Peter Chen <peter.chen@kernel.org>,
	Roger Quadros <rogerq@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <quic_pkondeti@quicinc.com>,
	<quic_ppratap@quicinc.com>
Subject: Re: [PATCH 1/2] usb: xhci: refactor quirks and plat private data
Date: Tue, 22 Feb 2022 14:57:14 +0530	[thread overview]
Message-ID: <efd3c978-6d37-a386-4953-758df73e1e1f@quicinc.com> (raw)
In-Reply-To: <CAE-0n522ctciYfxCxKqF0p3QFWcZU03nP5HoKsc=uKnokg7BCQ@mail.gmail.com>


On 2/16/2022 7:43 AM, Stephen Boyd wrote:
> Quoting Sandeep Maheswaram (2022-02-15 10:24:13)
>> From: Pavankumar Kondeti <quic_pkondeti@quicinc.com>
>>
>> This refactoring allows drivers like dwc3 host glue driver to
>> specify their xhci quirks.
>>
>> Signed-off-by: Pavankumar Kondeti <quic_pkondeti@quicinc.com>
> Your SoB should be here as well.
okay. Will add in next version.
>
>> diff --git a/include/linux/usb/xhci-plat.h b/include/linux/usb/xhci-plat.h
>> new file mode 100644
>> index 0000000..58a56ae
>> --- /dev/null
>> +++ b/include/linux/usb/xhci-plat.h
>> @@ -0,0 +1,24 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * xhci-plat.h - xHCI host controller driver platform Bus Glue.
>> + *
>> + * Copyright (C) 2015 Renesas Electronics Corporation
>> + */
>> +
>> +#ifndef _XHCI_PLAT_H
>> +#define _XHCI_PLAT_H
>> +
>> +#include <linux/types.h>
>> +#include <linux/usb/hcd.h>
> It would be great to remove this include and forward declare struct
> usb_hcd instead to avoid include hell. Maybe a followup patch?
okay.  Will do in next version.
>> +
>> +struct xhci_plat_priv {
>> +       const char *firmware_name;
>> +       unsigned long long quirks;
>> +       int (*plat_setup)(struct usb_hcd *hcd);
>> +       void (*plat_start)(struct usb_hcd *hcd);
>> +       int (*init_quirk)(struct usb_hcd *hcd);
>> +       int (*suspend_quirk)(struct usb_hcd *hcd);
>> +       int (*resume_quirk)(struct usb_hcd *hcd);
>> +};
>> +
>> +#endif /* _XHCI_PLAT_H */