From: Denis Kenzior <denkenz at gmail.com>
To: ell at lists.01.org
Subject: Re: [PATCH 1/2] cert-crypto: pragma false positive (-Wmaybe-uninitialized)
Date: Fri, 10 Jun 2022 12:16:11 -0500 [thread overview]
Message-ID: <1ea3b31f-13d9-ba52-6ba7-48ee4535d09e@gmail.com> (raw)
In-Reply-To: 20220610171132.334641-1-prestwoj@gmail.com
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
Hi James,
On 6/10/22 12:11, James Prestwood wrote:
> On musl-gcc 'bmpstring' was detected as maybe uninitialized. This
> is actually a false positive since the usage is guarded by
> if (p_len) but the compiler isn't aware. Pragma to ignore this
> warning.
>
> ell/cert-crypto.c: In function 'cert_pkcs12_pbkdf':
> ell/cert-crypto.c:246:17: error: 'bmpstring' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 246 | explicit_bzero(bmpstring, passwd_len);
> ---
> ell/cert-crypto.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Both applied, thanks.
Regards,
-Denis
next reply other threads:[~2022-06-10 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 17:16 Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-10 17:11 [PATCH 1/2] cert-crypto: pragma false positive (-Wmaybe-uninitialized) James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ea3b31f-13d9-ba52-6ba7-48ee4535d09e@gmail.com \
--to=ell@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).