[PATCH] genl: Return false, not NULL, for boolean return.

[PATCH] genl: Return false, not NULL, for boolean return.

[Ossama Othman]

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]

From: Ossama Othman <ossama.othman@gmail.com>

The return type of the l_genl_request_family() function is bool, not a
pointer.  Return false instead of NULL to match the return type.
---
 ell/genl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ell/genl.c b/ell/genl.c
index 7e3f800..97457cf 100644
--- a/ell/genl.c
+++ b/ell/genl.c
@@ -1538,11 +1538,11 @@ LIB_EXPORT bool l_genl_request_family(struct l_genl *genl, const char *name,
 	struct family_request *req;
 
 	if (unlikely(!genl) || unlikely(!name))
-		return NULL;
+		return false;
 
 	len = strlen(name);
 	if (unlikely(strlen(name) >= GENL_NAMSIZ))
-		return NULL;
+		return false;
 
 	req = l_new(struct family_request, 1);
 	req->appeared_func = appeared_func;
-- 
2.25.1

Re: [PATCH] genl: Return false, not NULL, for boolean return.

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

Hi Ossama,

On 3/12/21 1:04 PM, Ossama Othman wrote:
> From: Ossama Othman <ossama.othman@gmail.com>
> 
> The return type of the l_genl_request_family() function is bool, not a
> pointer.  Return false instead of NULL to match the return type.
> ---
>   ell/genl.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied, thanks.

Regards,
-Denis