Re: [PATCH 01/15] netconfig: Add missing NULL check for routes from RA

Re: [PATCH 01/15] netconfig: Add missing NULL check for routes from RA

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

Hi Andrew,

On 5/20/22 10:43, Andrew Zaborowski wrote:
> Fixes: 7a137bcac31e ("netconfig: Create routes from Router Advertisements")
> ---
>   ell/netconfig.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 

Patches 1-3 applied, thanks.

Regards,
-Denis

[PATCH 01/15] netconfig: Add missing NULL check for routes from RA

[Andrew Zaborowski]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

Fixes: 7a137bcac31e ("netconfig: Create routes from Router Advertisements")
---
 ell/netconfig.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/ell/netconfig.c b/ell/netconfig.c
index f39f88f..8026c81 100644
--- a/ell/netconfig.c
+++ b/ell/netconfig.c
@@ -573,8 +573,9 @@ static struct l_rtnl_route *netconfig_add_icmp6_route(struct l_netconfig *nc,
 {
 	struct l_rtnl_route *rt;
 
-	rt = netconfig_route_new(nc, AF_INET6, dst->address, dst->prefix_len,
-					gateway, RTPROT_RA);
+	rt = netconfig_route_new(nc, AF_INET6, dst ? dst->address : NULL,
+					dst ? dst->prefix_len : 0, gateway,
+					RTPROT_RA);
 	if (L_WARN_ON(!rt))
 		return NULL;
 
-- 
2.32.0