Re: [PATCH 04/17] netconfig: Create routes from Router Advertisements

[Denis Kenzior <denkenz at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

Hi Andrew,

On 5/13/22 17:47, Andrew Zaborowski wrote:
> If IPv6 is enabled, create the ICMP6 client and handle Router
> Advertisements received by creating, updating and removing routes per
> the data in the Router Advertisements.  Timeouts aren't handled yet.
> ---
>   ell/netconfig.c | 293 +++++++++++++++++++++++++++++++++++++++++++++---
>   1 file changed, 278 insertions(+), 15 deletions(-)
> 

<snip>

> +static void netconfig_icmp6_event_handler(struct l_icmp6_client *client,
> +						enum l_icmp6_client_event event,
> +						void *event_data,
> +						void *user_data)
> +{
> +	struct l_netconfig *nc = user_data;
> +	const struct l_icmp6_router *r;
> +	struct l_rtnl_route *default_route;
> +	unsigned int i;
> +
> +	if (event != L_ICMP6_CLIENT_EVENT_ROUTER_FOUND)
> +		return;
> +
> +	r = event_data;
> +
> +	/*
> +	 * Note: If this is the first RA received, the l_dhcp6_client
> +	 * will have received the event before us and will be acting
> +	 * on it by now.
> +	 */
> +
> +	if (nc->v4_gateway_override)
> +		return;
> +

So I think you meant v6_gateway_override here and I fixed this up accordingly. 
Send a fix if this wasn't correct.

Patches 1-4 applied, thanks.

Regards,
-Denis