Re: [PATCH 01/11] net: Add l_net_subnet_matches

[Andrew Zaborowski <andrew.zaborowski at intel.com>]

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

Hi Denis,

On Mon, 18 Apr 2022 at 18:34, Denis Kenzior <denkenz(a)gmail.com> wrote:
> > +     return !bits ||
> > +             ((((const uint8_t *) a)[bytes] ^ ((const uint8_t *) b)[bytes]) &
> > +              (0xff00u >> bits)) == 0;
>
> There were a bit too many '()' for my liking.  I moved the casts to the variable
> declaration block above which ended up being the same number of lines and looked
> a bit cleaner.

Do we want to do the array[bytes] access after the !bits check to
avoid accessing the byte after the end of the address for weird cases
where the prefix_len is exactly the number of bits in the two buffers
we received.

Best regards