From: Denis Kenzior <denkenz at gmail.com>
To: ell at lists.01.org
Subject: Re: [PATCH] dhcp: Use bound_time for retransmission timers
Date: Wed, 18 May 2022 11:21:45 -0500 [thread overview]
Message-ID: <a1c01d0b-5cb9-9ca6-2da4-c7f99cd1c9ff@gmail.com> (raw)
In-Reply-To: 20220511172855.25992-1-denkenz@gmail.com
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On 5/11/22 12:28, Denis Kenzior wrote:
> start_t is used to try and calculate the retransmission timeout value
> when the client enters RENEWING or REBINDING state. This works fine on
> the first renewal since the client start timestamp and the lease bound
> timestamp are very close. Also, the RENEW request is sent immediately
> whenever the T1 timer expires and most of the time it succeeds.
>
> However, if this isn't a first renewal attempt and the RENEW request
> sent when the T1 timer expires is not successful, then the renewal
> timeout value could become too large. Fix that by using the lease
> bound_time for the retransmission timer calculation (as intended) intead
> of the client start time (start_t).
> ---
> ell/dhcp.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
Applied.
next reply other threads:[~2022-05-18 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 16:21 Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-13 17:10 [PATCH] dhcp: Use bound_time for retransmission timers Michael Johnson
2022-05-13 16:23 Denis Kenzior
2022-05-13 15:40 Michael Johnson
2022-05-13 15:31 Michael Johnson
2022-05-13 14:30 Denis Kenzior
2022-05-13 13:53 Michael Johnson
2022-05-11 17:28 Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1c01d0b-5cb9-9ca6-2da4-c7f99cd1c9ff@gmail.com \
--to=ell@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).