ell.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH v2] cert: Fix warning of possible uninitialized var
Date: Fri, 22 Jan 2021 10:15:21 -0600	[thread overview]
Message-ID: <f4fb9995-4f47-1c33-c857-e60de7c93ea8@gmail.com> (raw)
In-Reply-To: <20210118182028.964376-1-brian.gix@intel.com>

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

Andrew,

On 1/18/21 12:20 PM, Brian Gix wrote:
> ell/cert-crypto.c: In function ‘cert_pkcs12_pbkdf’:
> ell/cert-crypto.c:244:3: error: ‘bmpstring’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>    244 |   explicit_bzero(bmpstring, passwd_len);
>        |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ---
>   ell/cert-crypto.c | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
> 

Do you have any comments on this patch or should I take it in?

Regards,
-Denis

  reply	other threads:[~2021-01-22 16:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 18:20 [PATCH v2] cert: Fix warning of possible uninitialized var Brian Gix
2021-01-22 16:15 ` Denis Kenzior [this message]
2021-01-22 22:29   ` Andrew Zaborowski
2021-01-25 16:34 ` Denis Kenzior
2021-01-25 17:40   ` Gix, Brian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4fb9995-4f47-1c33-c857-e60de7c93ea8@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ell@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).