Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static

From: Jason Yan <yanaijie@huawei.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	<f.fainelli@gmail.com>, <tglx@linutronix.de>,
	<jason@lakedaemon.net>, <justinpopo6@gmail.com>,
	<bcm-kernel-feedback-list@broadcom.com>,
	<linux-mips@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static
Date: Fri, 17 Apr 2020 19:10:15 +0800	[thread overview]
Message-ID: <f06da401-1083-c0c7-17a9-7a3fe0476820@huawei.com> (raw)
In-Reply-To: <a71e75e8e391c76bf2f260abbaad4f9d@kernel.org>

在 2020/4/17 19:07, Marc Zyngier 写道:
> On 2020-04-17 11:56, Jason Yan wrote:
>> 在 2020/4/17 18:26, Sergei Shtylyov 写道:
>>> Hello!
>>>
>>> On 17.04.2020 10:40, Jason Yan wrote:
>>>
>>>> Fix the following sparse warning:
>>>>
>>>> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
>>>> 'bcm7038_l1_of_init' was not declared. Should it be static?
>>>>
>>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>>>> ---
>>>>   drivers/irqchip/irq-bcm7038-l1.c | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c 
>>>> b/drivers/irqchip/irq-bcm7038-l1.c
>>>> index eb9bce93cd05..fd7c537fb42a 100644
>>>> --- a/drivers/irqchip/irq-bcm7038-l1.c
>>>> +++ b/drivers/irqchip/irq-bcm7038-l1.c
>>>> @@ -416,7 +416,7 @@ static const struct irq_domain_ops 
>>>> bcm7038_l1_domain_ops = {
>>>>       .map            = bcm7038_l1_map,
>>>>   };
>>>> -int __init bcm7038_l1_of_init(struct device_node *dn,
>>>> +static int __init bcm7038_l1_of_init(struct device_node *dn,
>>>>                     struct device_node *parent)
>>>
>>>     Reindent the above line please, it should start under *struct* on 
>>> the 1st line.
>>
>> OK, will cook a new one.
> 
> Please don't bother. I've picked the patch already, and it is on its way 
> to Linus.
> 

I have send v2 before I saw this. You can just ignore it.

Thanks,

Jason

> Thanks,
> 
>          M.