From: Daniel Borkmann <daniel@iogearbox.net>
To: Martin KaFai Lau <kafai@fb.com>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
David Miller <davem@davemloft.net>,
kernel-team@fb.com, netdev@vger.kernel.org
Subject: Re: [PATCH bpf] bpf: selftests: Fix error checking on reading the tcp_fastopen sysctl
Date: Wed, 12 Feb 2020 17:50:27 +0100 [thread overview]
Message-ID: <f092bb3b-aad4-1685-7b69-b669fae51471@iogearbox.net> (raw)
In-Reply-To: <20200211175910.3235321-1-kafai@fb.com>
On 2/11/20 6:59 PM, Martin KaFai Lau wrote:
> There is a typo in checking the "saved_tcp_fo" and instead
> "saved_tcp_syncookie" is checked again. This patch fixes it
> and also breaks them into separate if statements such that
> the test will abort asap.
>
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Applied, thanks!
prev parent reply other threads:[~2020-02-12 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 17:59 [PATCH bpf] bpf: selftests: Fix error checking on reading the tcp_fastopen sysctl Martin KaFai Lau
2020-02-12 0:40 ` Andrii Nakryiko
2020-02-12 16:50 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f092bb3b-aad4-1685-7b69-b669fae51471@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.