All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v4 04/11] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.
Date: Wed, 6 May 2020 15:35:49 +0200	[thread overview]
Message-ID: <f1c87c45-0c81-c791-b2a8-e50929c46d8b@linux.intel.com> (raw)
In-Reply-To: <20200430230951.2508-5-manasi.d.navare@intel.com>

Op 01-05-2020 om 01:09 schreef Manasi Navare:
> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Small changes to intel_dp_mode_valid(), allow listing modes that
> can only be supported in the bigjoiner configuration, which is
> not supported yet.
>
> eDP does not support bigjoiner, so do not expose bigjoiner only
> modes on the eDP port.
>
> Changes since v1:
> - Disallow bigjoiner on eDP.
> Changes since v2:
> - Rename intel_dp_downstream_max_dotclock to intel_dp_max_dotclock,
>   and split off the downstream and source checking to its own function.
>   (Ville)
> v3:
> * Rebase (Manasi)
>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 117 ++++++++++++++++++------
>  1 file changed, 89 insertions(+), 28 deletions(-)

Hey,

With this patch, the 8k mode is still rejected because h limits are not increased on DP:
[ 3762.916623] i915 0000:00:02.0: [drm:intel_dp_dsc_get_output_bpp [i915]] Max link bpp: 12
[ 3762.916663] i915 0000:00:02.0: [drm:intel_dp_dsc_get_output_bpp [i915]] Max small joiner bpp: 16
[ 3762.916702] [drm:intel_dp_dsc_get_output_bpp [i915]] Max big joiner bpp: 14
[ 3762.916706] [drm:drm_mode_debug_printmodeline] Modeline "7680x4320": 60 2068660 7680 7688 7720 7760 4320 4429 4437 4443 0x48 0x9
[ 3762.916709] [drm:drm_mode_prune_invalid] Not using 7680x4320 mode: H_ILLEGAL

I would suggest tweaking intel_mode_valid_max_plane_size to make this work. :)

~Maarten

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-05-06 13:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 23:09 [Intel-gfx] [PATCH v4 00/11] Rebased Big Joiner patch series for 8K 2p1p Manasi Navare
2020-04-30 23:09 ` [Intel-gfx] [PATCH v4 01/11] HAX to make DSC work on the icelake test system Manasi Navare
2020-04-30 23:09 ` [Intel-gfx] [PATCH v4 02/11] drm/i915: Remove hw.mode Manasi Navare
2020-04-30 23:09 ` [Intel-gfx] [PATCH v4 03/11] drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split Manasi Navare
2020-05-01  5:06   ` kbuild test robot
2020-05-01  5:18   ` [Intel-gfx] [PATCH v5 " Manasi Navare
2020-04-30 23:09 ` [Intel-gfx] [PATCH v4 04/11] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3 Manasi Navare
2020-05-06 13:35   ` Maarten Lankhorst [this message]
2020-04-30 23:09 ` [Intel-gfx] [PATCH v4 05/11] drm/i915: Try to make bigjoiner work in atomic check Manasi Navare
2020-04-30 23:09 ` [Intel-gfx] [PATCH v4 06/11] drm/i915: Enable big joiner support in enable and disable sequences Manasi Navare
2020-04-30 23:09 ` [Intel-gfx] [PATCH v4 07/11] drm/i915: Make hardware readout work on i915 Manasi Navare
2020-04-30 23:09 ` [Intel-gfx] [PATCH v4 08/11] drm/i915: Link planes in a bigjoiner configuration, v3 Manasi Navare
2020-04-30 23:09 ` [Intel-gfx] [PATCH v4 09/11] drm/i915: Add bigjoiner aware plane clipping checks Manasi Navare
2020-04-30 23:09 ` [Intel-gfx] [PATCH v4 10/11] drm/i915: Add intel_update_bigjoiner handling Manasi Navare
2020-04-30 23:09 ` [Intel-gfx] [PATCH v4 11/11] drm/i915: Add debugfs dumping for bigjoiner, v3 Manasi Navare
2020-04-30 23:57 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Rebased Big Joiner patch series for 8K 2p1p Patchwork
2020-05-01  5:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Rebased Big Joiner patch series for 8K 2p1p (rev2) Patchwork
2020-05-01  5:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-05-01  9:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-05-06 14:45 ` [Intel-gfx] [PATCH v4 00/11] Rebased Big Joiner patch series for 8K 2p1p Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1c87c45-0c81-c791-b2a8-e50929c46d8b@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=manasi.d.navare@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.