From: Lukasz Luba <lukasz.luba@arm.com>
To: daniel.lezcano@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
khilman@baylibre.com, abailon@baylibre.com,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Todd Kjos <tkjos@google.com>, Wei Wang <wvw@google.com>,
rafael@kernel.org, Daniel Lezcano <daniel.lezcano@linexp.org>
Subject: Re: [PATCH v3 05/12] thermal/core: Remove unneeded EXPORT_SYMBOLS
Date: Tue, 5 Jul 2022 08:30:26 +0100 [thread overview]
Message-ID: <f1cd08de-e8cb-18c2-9f92-01436810bc20@arm.com> (raw)
In-Reply-To: <e2d81210-a969-fe9d-a4fb-1826c991fbce@linexp.org>
On 7/4/22 22:14, Daniel Lezcano wrote:
> On 04/07/2022 09:35, Lukasz Luba wrote:
>> Hi Daniel,
>>
>> (+Todd and Wei on CC)
>>
>>
>> On 7/3/22 19:30, Daniel Lezcano wrote:
>
> [ ... ]
>
>>> }
>>> -EXPORT_SYMBOL(get_tz_trend);
>
> [ ... ]
>
>>> }
>>> -EXPORT_SYMBOL(thermal_cdev_update);
>>
>> I wouldn't remove that export. I can see in my Pixel6 modules dir, that
>> it's called in 7 places.
>>
>> I assume that in Android world this is common use.
>
> It is not possible to do changes taking into consideration out of tree
> code. Moreover there is logically no good reason to use the
> thermal_cdev_update() function from outside of the thermal core code.
>
I see your point which is 'upstream'. On the other hand the mostly
deployed kernel is in Android devices and that brings a lot to the
community.
This symbol might also be used by other distros which might have
modules for some accelerators, which also support tricky cooling.
I would keep it as is...
next prev parent reply other threads:[~2022-07-05 7:30 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-03 18:30 [PATCH v3 00/12] thermal OF rework Daniel Lezcano
2022-07-03 18:30 ` [PATCH v3 01/12] thermal/core: Remove duplicate information when an error occurs Daniel Lezcano
2022-07-04 7:38 ` Lukasz Luba
2022-07-03 18:30 ` [PATCH v3 02/12] thermal/of: Replace device node match with device node search Daniel Lezcano
2022-07-04 7:59 ` Lukasz Luba
2022-07-04 21:18 ` Daniel Lezcano
2022-07-03 18:30 ` [PATCH v3 03/12] thermal/of: Remove the device node pointer for thermal_trip Daniel Lezcano
2022-07-04 8:01 ` Lukasz Luba
2022-07-03 18:30 ` [PATCH v3 04/12] thermal/of: Move thermal_trip structure to thermal.h Daniel Lezcano
2022-07-04 8:04 ` Lukasz Luba
2022-07-03 18:30 ` [PATCH v3 05/12] thermal/core: Remove unneeded EXPORT_SYMBOLS Daniel Lezcano
2022-07-04 7:35 ` Lukasz Luba
2022-07-04 21:14 ` Daniel Lezcano
2022-07-05 7:30 ` Lukasz Luba [this message]
2022-07-05 14:20 ` Rafael J. Wysocki
2022-07-05 14:47 ` Lukasz Luba
2022-07-05 16:26 ` Todd Kjos
2022-07-03 18:30 ` [PATCH v3 06/12] thermal/core: Move thermal_set_delay_jiffies to static Daniel Lezcano
2022-07-04 8:05 ` Lukasz Luba
2022-07-03 18:30 ` [PATCH v3 07/12] thermal/core: Rename trips to ntrips Daniel Lezcano
2022-07-04 8:24 ` Lukasz Luba
2022-07-04 14:17 ` Zhang Rui
2022-07-04 21:19 ` Daniel Lezcano
2022-07-03 18:30 ` [PATCH v3 08/12] thermal/core: Add thermal_trip in thermal_zone Daniel Lezcano
2022-07-04 8:35 ` Lukasz Luba
2022-07-04 14:11 ` Zhang Rui
2022-07-04 21:20 ` Daniel Lezcano
2022-07-03 18:30 ` [PATCH v3 09/12] thermal/core: Register with the trip points Daniel Lezcano
2022-07-04 8:32 ` Lukasz Luba
2022-07-05 2:03 ` Zhang Rui
2022-07-05 13:59 ` Rafael J. Wysocki
2022-07-03 18:30 ` [PATCH v3 10/12] thermal/of: Store the trips in the thermal zone Daniel Lezcano
2022-07-04 8:38 ` Lukasz Luba
2022-07-03 18:30 ` [PATCH v3 11/12] thermal/of: Use thermal trips stored " Daniel Lezcano
2022-07-04 14:14 ` Zhang Rui
2022-07-04 21:24 ` Daniel Lezcano
2022-07-05 1:20 ` Zhang Rui
2022-07-05 6:44 ` Daniel Lezcano
2022-07-05 8:17 ` Zhang Rui
2022-07-03 18:30 ` [PATCH v3 12/12] thermal/of: Initialize trip points separately Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1cd08de-e8cb-18c2-9f92-01436810bc20@arm.com \
--to=lukasz.luba@arm.com \
--cc=abailon@baylibre.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=daniel.lezcano@linexp.org \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=tkjos@google.com \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.