From: Jan Kiszka <jan.kiszka@siemens.com>
To: Srinuvasan A <Srinuvasan_A@mentor.com>, cip-dev@lists.cip-project.org
Subject: Re: [isar-cip-dev] [PATCH] recipes-core/swupdate: Update the SRC_URI and SWUPDATE_BUILD_PROFILES append for buster
Date: Thu, 28 Oct 2021 15:46:18 +0200 [thread overview]
Message-ID: <f1d37383-5262-910f-4791-f42a8f16cb66@siemens.com> (raw)
In-Reply-To: <20211028111544.603217-1-Srinuvasan_A@mentor.com>
On 28.10.21 13:15, Srinuvasan A wrote:
> From: Srinuvasan A <srinuvasan_a@mentor.com>
>
> When we build the swupdate debian package for buster some build
> dependency packages are not available in stable buster, hence we created a
> patch in cip-core upstream for buster build, here we hardcoded the distro
> for buster build hence it is building fine in cip-core not the
> downstream layer, added the "DISTRO" variable to pick the proper distro name.
>
> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
> recipes-core/swupdate/swupdate_2021.04-1+debian-gbp.bb | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/recipes-core/swupdate/swupdate_2021.04-1+debian-gbp.bb b/recipes-core/swupdate/swupdate_2021.04-1+debian-gbp.bb
> index a451b55..f8298f0 100644
> --- a/recipes-core/swupdate/swupdate_2021.04-1+debian-gbp.bb
> +++ b/recipes-core/swupdate/swupdate_2021.04-1+debian-gbp.bb
> @@ -35,14 +35,14 @@ SWUPDATE_BUILD_PROFILES += "pkg.swupdate.nosigning pkg.swupdate.noencryption"
> # SWUPDATE_BUILD_PROFILES += "pkg.swupdate.embeddedlua"
>
> # modify for debian buster build
> -SRC_URI_append_cip-core-buster = " file://0009-debian-prepare-build-for-isar-debian-buster.patch"
> +SRC_URI_append_${DISTRO} = " file://0009-debian-prepare-build-for-isar-debian-buster.patch"
This makes no sense. DISTRO is in OVERRIDES, so this will always match.
And that would also not make sense for a patch that is for buster only.
You likely want to match on BASE_DISTRO_CODENAME. That means expanding
OVERRIDES accordingly.
Jan
>
> # disable documentation due to missing packages in debian buster
> # disable create filesystem due to missing symbols in debian buster
> # disable webserver due to missing symbols in debian buster
> -SWUPDATE_BUILD_PROFILES_append_cip-core-buster = " nodoc \
> - pkg.swupdate.nocreatefs \
> - pkg.swupdate.nowebserver "
> +SWUPDATE_BUILD_PROFILES_append_${DISTRO} = " nodoc \
> + pkg.swupdate.nocreatefs \
> + pkg.swupdate.nowebserver "
> # In debian buster the git-compression defaults to gz and does not detect other
> # compression formats.
> GBP_EXTRA_OPTIONS += "--git-compression=xz"
>
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2021-10-28 13:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 11:15 [isar-cip-dev] [PATCH] recipes-core/swupdate: Update the SRC_URI and SWUPDATE_BUILD_PROFILES append for buster Srinuvasan A
2021-10-28 13:46 ` Jan Kiszka [this message]
2021-10-29 5:39 ` Srinuvasan A
2021-10-29 15:08 ` Jan Kiszka
2021-11-02 10:39 ` Srinuvasan A
2021-11-02 10:41 ` [isar-cip-dev] " Srinuvasan A
2021-11-02 20:12 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1d37383-5262-910f-4791-f42a8f16cb66@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=Srinuvasan_A@mentor.com \
--cc=cip-dev@lists.cip-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.