From: David Laight <David.Laight@ACULAB.COM>
To: 'Stanimir Varbanov' <stanimir.varbanov@linaro.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Vikash Garodia <vgarodia@codeaurora.org>,
Mansur Alisha Shaik <mansur@codeaurora.org>
Subject: RE: [PATCH v2 2/5] venus: Make sys_error flag an atomic bitops
Date: Wed, 9 Jun 2021 16:03:03 +0000 [thread overview]
Message-ID: <f1da15793122432e856b5f0b00f2cf6f@AcuMS.aculab.com> (raw)
In-Reply-To: <20210608114156.87018-3-stanimir.varbanov@linaro.org>
From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> Sent: 08 June 2021 12:42
>
> Make the sys_error flag an atomic bitops in order to avoid
> locking in sys_error readers.
I don't think that makes any difference at all.
It is only atomic w.r.t other bitops in the same bitmap.
Even if it contained the fullest memory barrier you can
imagine the result of test_bit() is immediately stale.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-06-09 16:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 11:41 [PATCH v2 0/5] Venus fatal error handling Stanimir Varbanov
2021-06-08 11:41 ` [PATCH v2 1/5] venus: venc: Use pmruntime autosuspend Stanimir Varbanov
2021-06-08 11:41 ` [PATCH v2 2/5] venus: Make sys_error flag an atomic bitops Stanimir Varbanov
2021-06-09 16:03 ` David Laight [this message]
2021-06-08 11:41 ` [PATCH v2 3/5] venus: hfi: Check for sys error on session hfi functions Stanimir Varbanov
2021-06-08 11:41 ` [PATCH v2 4/5] venus: helpers: Add helper to mark fatal vb2 error Stanimir Varbanov
2021-06-08 11:41 ` [PATCH v2 5/5] venus: Handle fatal errors during encoding and decoding Stanimir Varbanov
2021-10-06 5:00 ` [PATCH v2 0/5] Venus fatal error handling vgarodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1da15793122432e856b5f0b00f2cf6f@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mansur@codeaurora.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.