Re: [PATCH] arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI

From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: tools@linux.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI
Date: Wed, 27 Dec 2023 01:53:34 +0100	[thread overview]
Message-ID: <f1dd06a5-d5f6-40bf-b4c9-5b073b329b04@linaro.org> (raw)
In-Reply-To: <20231222-smooth-jellyfish-of-vigor-1acab8@lemur>

On 22.12.2023 19:43, Konstantin Ryabitsev wrote:
> On Wed, Dec 20, 2023 at 03:16:00PM +0100, Konrad Dybcio wrote:
>> On 20.12.2023 15:15, Konrad Dybcio wrote:
>>> The SLPI is powered by the Low Power Island power rails. Fix the incorrect
>>> assignment.
>>>
>>> Fixes: 74588aada59a ("arm64: dts: qcom: sdm845: add SLPI remoteproc")
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>> b4 seems to not have included my "only compile-tested" comment
> 
> Can you let me know your expected behaviour vs. what you ended up seeing? 
Sure!

expected: the "Only compile-tested" bit goes under the striped
line

actual: The line is ignored. And I think this happens quite
consistently with a single patch with a single line of 'cover
letter' only, maybe it interprets the series topic, but a
separate 0/1 message is of course not created.

Here's the setup:

--------------------------------------------
commit f516d7b26e4aa2e6ac87f7e989de008a99e5b26b (topic/sdm845_slpi_lcxmx)
Author: Konrad Dybcio <konrad.dybcio@linaro.org>
Date:   Wed Dec 20 15:12:56 2023 +0100

    arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI

    The SLPI is powered by the Low Power Island power rails. Fix the incorrect
    assignment.

    Fixes: 74588aada59a ("arm64: dts: qcom: sdm845: add SLPI remoteproc")
    Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

commit d8d0c7257dd4cba8ca0f9f8cdfc7ab12adfd3909
Author: Konrad Dybcio <konrad.dybcio@linaro.org>
Date:   Wed Dec 20 15:14:34 2023 +0100

    Only compile-tested

    To: Bjorn Andersson <andersson@kernel.org>
    To: Rob Herring <robh+dt@kernel.org>
    To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
    To: Conor Dooley <conor+dt@kernel.org>
    To: Dylan Van Assche <me@dylanvanassche.be>
    Cc: Marijn Suijten <marijn.suijten@somainline.org>
    Cc: linux-arm-msm@vger.kernel.org
    Cc: devicetree@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Cc: Caleb Connolly <caleb.connolly@linaro.org>
    Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

    ---
    Changes in v2:
    - EDITME: describe what is new in this series revision.
    - EDITME: use bulletpoints and terse descriptions.
    - Link to v1: https://lore.kernel.org/r/20231220-topic-sdm845_slpi_lcxmx-v1-1-db7c72ef99ae@linaro.org

    --- b4-submit-tracking ---
    # This section is used internally by b4 prep for tracking purposes.
    {
      "series": {
        "revision": 2,
        "change-id": "20231220-topic-sdm845_slpi_lcxmx-03c4f98a423d",
        "base-branch": null,
        "prefixes": [],
        "history": {
          "v1": [
            "20231220-topic-sdm845_slpi_lcxmx-v1-1-db7c72ef99ae@linaro.org"
          ]
        }
      }
    }

commit 20d857259d7d10cd0d5e8b60608455986167cfad (tag: next-20231220)

--------------------------------------------

Konrad