From: Adrian Hunter <adrian.hunter@intel.com>
To: Yue Haibing <yuehaibing@huawei.com>,
kishon@ti.com, ulf.hansson@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static
Date: Mon, 25 Mar 2019 12:17:38 +0200 [thread overview]
Message-ID: <f2582cc7-e8e4-8e39-311b-eb0dd46dec3f@intel.com> (raw)
In-Reply-To: <20190322141138.19244-1-yuehaibing@huawei.com>
On 22/03/19 4:11 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/mmc/host/sdhci-omap.c:788:6: warning:
> symbol 'sdhci_omap_reset' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 5bbed47..649c03f 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -785,7 +785,7 @@ static void sdhci_omap_set_uhs_signaling(struct sdhci_host *host,
> sdhci_omap_start_clock(omap_host);
> }
>
> -void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
> +static void sdhci_omap_reset(struct sdhci_host *host, u8 mask)
> {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
>
next prev parent reply other threads:[~2019-03-25 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 14:11 [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static Yue Haibing
2019-03-22 14:11 ` Yue Haibing
2019-03-22 14:19 ` Faiz Abbas
2019-03-22 14:19 ` Faiz Abbas
2019-03-25 10:17 ` Adrian Hunter [this message]
2019-03-25 13:27 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2582cc7-e8e4-8e39-311b-eb0dd46dec3f@intel.com \
--to=adrian.hunter@intel.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.