From: <Claudiu.Beznea@microchip.com>
To: <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] clk: at91: fix update bit maps on CFG_MOR write
Date: Mon, 16 Sep 2019 05:24:23 +0000 [thread overview]
Message-ID: <f2a0f3ac-21b3-17d1-8677-2e55be18dfa5@microchip.com> (raw)
In-Reply-To: <1568042692-11784-1-git-send-email-eugen.hristev@microchip.com>
On 09.09.2019 18:30, Eugen.Hristev@microchip.com wrote:
> External E-Mail
>
>
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> The regmap update bits call was not selecting the proper mask, considering
> the bits which was updating.
> Update the mask from call to also include OSCBYPASS.
> Removed MOSCEN which was not updated.
>
> Fixes: 1bdf02326b71 ("clk: at91: make use of syscon/regmap internally")
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/clk/at91/clk-main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/at91/clk-main.c b/drivers/clk/at91/clk-main.c
> index f607ee7..ebe9b99 100644
> --- a/drivers/clk/at91/clk-main.c
> +++ b/drivers/clk/at91/clk-main.c
> @@ -152,7 +152,7 @@ at91_clk_register_main_osc(struct regmap *regmap,
> if (bypass)
> regmap_update_bits(regmap,
> AT91_CKGR_MOR, MOR_KEY_MASK |
> - AT91_PMC_MOSCEN,
> + AT91_PMC_OSCBYPASS,
> AT91_PMC_OSCBYPASS | AT91_PMC_KEY);
>
> hw = &osc->hw;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-16 5:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 15:30 [PATCH 1/2] clk: at91: fix update bit maps on CFG_MOR write Eugen.Hristev
2019-09-09 15:30 ` Eugen.Hristev
2019-09-09 15:30 ` [PATCH 2/2] clk: at91: select parent if main oscillator or bypass is enabled Eugen.Hristev
2019-09-09 15:30 ` Eugen.Hristev
2019-09-11 12:21 ` Alexandre Belloni
2019-09-11 12:21 ` Alexandre Belloni
2019-09-16 5:25 ` Claudiu.Beznea
2019-09-16 20:15 ` Stephen Boyd
2019-09-16 20:15 ` Stephen Boyd
2019-09-10 15:16 ` [PATCH 1/2] clk: at91: fix update bit maps on CFG_MOR write Alexandre Belloni
2019-09-10 15:16 ` Alexandre Belloni
2019-09-16 5:24 ` Claudiu.Beznea [this message]
2019-09-16 20:15 ` Stephen Boyd
2019-09-16 20:15 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2a0f3ac-21b3-17d1-8677-2e55be18dfa5@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.