Re: [PATCH] hw/xenpv: Initialize Xen backend operations

From: Paul Durrant <xadimgnik@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	Joao Martins <joao.m.martins@oracle.com>,
	Ankur Arora <ankur.a.arora@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	vikram.garhwal@amd.com, xen-devel@lists.xenproject.org,
	Juan Quintela <quintela@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] hw/xenpv: Initialize Xen backend operations
Date: Thu, 23 Mar 2023 13:26:27 +0000	[thread overview]
Message-ID: <f2f3ddbc-c39f-a0b9-3174-a95d5e391bdd@xen.org> (raw)
In-Reply-To: <5dfb65342d4502c1ce2f890c97cff20bf25b3860.camel@infradead.org>

On 23/03/2023 10:57, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
> 
> As the Xen backend operations were abstracted out into a function table to
> allow for internally emulated Xen support, we missed the xen_init_pv()
> code path which also needs to install the operations for the true Xen
> libraries. Add the missing call to setup_xen_backend_ops().
> 
> Fixes: b6cacfea0b38 ("hw/xen: Add evtchn operations to allow redirection to internal emulation")
> Reported-by: Anthony PERARD <anthony.perard@citrix.com>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
>   hw/xenpv/xen_machine_pv.c | 2 ++
>   1 file changed, 2 insertions(+)

Reviewed-by: Paul Durrant <paul@xen.org>

> 
> diff --git a/hw/xenpv/xen_machine_pv.c b/hw/xenpv/xen_machine_pv.c
> index 2e759d0619..17cda5ec13 100644
> --- a/hw/xenpv/xen_machine_pv.c
> +++ b/hw/xenpv/xen_machine_pv.c
> @@ -35,6 +35,8 @@ static void xen_init_pv(MachineState *machine)
>       DriveInfo *dinfo;
>       int i;
>   
> +    setup_xen_backend_ops();
> +
>       /* Initialize backend core & drivers */
>       xen_be_init();
>