From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH v3 1/4] xen: use common output function in debugtrace
Date: Tue, 3 Sep 2019 13:47:58 +0200 [thread overview]
Message-ID: <f373132d-ba9c-45b2-8b2d-d1833f43870c@suse.com> (raw)
In-Reply-To: <f5bd649c-1dc2-080b-df0c-ef06d59da35b@suse.com>
On 03.09.2019 12:22, Juergen Gross wrote:
> On 03.09.19 12:00, Jan Beulich wrote:
>> On 28.08.2019 10:00, Juergen Gross wrote:
>>> Today dumping the debugtrace buffers is done via sercon_puts(), while
>>> direct printing of trace entries (after toggling output to the console)
>>> is using serial_puts().
>>>
>>> Use sercon_puts() in both cases, as the difference between both is not
>>> really making sense.
>>
>> No matter that I like this change, I'm not convinced it's correct:
>> There are two differences between the functions, neither of which
>> I could qualify as "not really making sense": Why is it obvious
>> that it makes no sense for the debugtrace output to bypass one or
>> both of serial_steal_fn() and pv_console_puts()? If you're
>> convinced of this, please provide the "why"-s behind the sentence
>> above.
>
> Okay, I'll use:
>
> Use sercon_puts() in both cases, to be consistent between dumping the
> buffer when switching debugtrace to console output and when printing
> a debugtrace entry directly to console.
Well, this is better as an explanation indeed, but it still doesn't
make clear whether it wasn't in fact wanted for there to be a
difference in where output gets sent. I may believe that bypassing
pv_console_puts() wasn't intended, but the steal function bypass
had been there in 3.2 already, so may well have been on purpose.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-03 11:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 8:00 [Xen-devel] [PATCH v3 0/4] xen: debugtrace cleanup and per-cpu buffer support Juergen Gross
2019-08-28 8:00 ` [Xen-devel] [PATCH v3 1/4] xen: use common output function in debugtrace Juergen Gross
2019-09-03 10:00 ` Jan Beulich
2019-09-03 10:22 ` Juergen Gross
2019-09-03 11:47 ` Jan Beulich [this message]
2019-09-03 11:58 ` Juergen Gross
2019-09-03 12:09 ` Jan Beulich
2019-09-03 12:22 ` Juergen Gross
2019-09-03 12:40 ` Jan Beulich
2019-08-28 8:00 ` [Xen-devel] [PATCH v3 2/4] xen: move debugtrace coding to common/debugtrace.c Juergen Gross
2019-09-03 10:02 ` Jan Beulich
2019-08-28 8:00 ` [Xen-devel] [PATCH v3 3/4] xen: refactor debugtrace data Juergen Gross
2019-09-03 10:16 ` Jan Beulich
2019-09-03 10:31 ` Juergen Gross
2019-09-03 11:50 ` Jan Beulich
2019-09-03 13:26 ` Juergen Gross
2019-08-28 8:00 ` [Xen-devel] [PATCH v3 4/4] xen: add per-cpu buffer option to debugtrace Juergen Gross
2019-09-03 10:51 ` Jan Beulich
2019-09-03 11:10 ` Juergen Gross
2019-09-03 12:01 ` Jan Beulich
2019-09-03 12:10 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f373132d-ba9c-45b2-8b2d-d1833f43870c@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.