All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	David Teigland <teigland@redhat.com>,
	Jeff Layton <jlayton@poochiereds.net>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/9] fs.h: Add argument names to struct file_lock_operations (*funcs)
Date: Sun, 20 Jul 2014 11:23:38 -0700	[thread overview]
Message-ID: <f3739fa3d66b206267cadac326eee3fc09a2fdc6.1405879494.git.joe@perches.com> (raw)
In-Reply-To: <cover.1405879494.git.joe@perches.com>

Function pointer struct members without argument type names
are not very clear.  Add them.

Signed-off-by: Joe Perches <joe@perches.com>
---
 include/linux/fs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 05be298..65685a7 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -834,8 +834,8 @@ static inline struct file *get_file(struct file *f)
 typedef void *fl_owner_t;
 
 struct file_lock_operations {
-	void (*fl_copy_lock)(struct file_lock *, struct file_lock *);
-	void (*fl_release_private)(struct file_lock *);
+	void (*fl_copy_lock)(struct file_lock *dst, struct file_lock *fl);
+	void (*fl_release_private)(struct file_lock *fl);
 };
 
 struct lock_manager_operations {
-- 
1.8.1.2.459.gbcd45b4.dirty


  parent reply	other threads:[~2014-07-20 18:25 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-20 18:23 [PATCH 0/9] fs.h/dlm: Neatening and argument removals Joe Perches
2014-07-20 18:23 ` [Cluster-devel] " Joe Perches
2014-07-20 18:23 ` [PATCH 1/9] fs.h: Remove unnecessary extern prototypes Joe Perches
2014-07-23 17:58   ` Jeff Layton
2014-07-20 18:23 ` [PATCH 2/9] fs.h: Whitespace neatening Joe Perches
2014-07-23 17:57   ` Jeff Layton
2014-07-20 18:23 ` [PATCH 3/9] fs.h: A few more whitespace neatenings Joe Perches
2014-07-23 18:12   ` Jeff Layton
2014-07-20 18:23 ` Joe Perches [this message]
2014-07-23 17:59   ` [PATCH 4/9] fs.h: Add argument names to struct file_lock_operations (*funcs) Jeff Layton
2014-07-20 18:23 ` [PATCH 5/9] fs.h: Add member argument descriptions to lock_manager_operations Joe Perches
2014-07-23 17:59   ` Jeff Layton
2014-07-20 18:23 ` [PATCH 6/9] dlm: plock: Add argument descriptions to notify Joe Perches
2014-07-20 18:23   ` [Cluster-devel] " Joe Perches
2014-07-20 18:23 ` [PATCH 7/9] dlm: fs: Remove unused conf from lm_grant Joe Perches
2014-07-20 18:23   ` [Cluster-devel] " Joe Perches
2014-07-23 18:00   ` Jeff Layton
2014-07-23 18:00     ` [Cluster-devel] " Jeff Layton
2014-07-23 18:00     ` Jeff Layton
2014-07-20 18:23 ` [PATCH 8/9] dlm: plock: Reduce indentation by rearranging order Joe Perches
2014-07-20 18:23   ` [Cluster-devel] " Joe Perches
2014-07-23 18:01   ` Jeff Layton
2014-07-23 18:01     ` [Cluster-devel] " Jeff Layton
2014-07-20 18:23 ` [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type Joe Perches
2014-07-20 18:23   ` [Cluster-devel] " Joe Perches
2014-07-20 18:23   ` Joe Perches
2014-07-23 18:11   ` Jeff Layton
2014-07-23 18:11     ` [Cluster-devel] " Jeff Layton
2014-07-23 18:11     ` Jeff Layton
2014-07-23 18:33     ` David Teigland
2014-07-23 18:33       ` [Cluster-devel] " David Teigland
2014-07-23 18:33       ` David Teigland
2014-07-24  3:53     ` Joe Perches
2014-07-24  3:53       ` [Cluster-devel] " Joe Perches
2014-07-24 16:24       ` Jeff Layton
2014-07-24 16:24         ` [Cluster-devel] " Jeff Layton
2014-07-24 16:24         ` Jeff Layton
2014-07-24 16:35         ` Joe Perches
2014-07-24 16:35           ` [Cluster-devel] " Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3739fa3d66b206267cadac326eee3fc09a2fdc6.1405879494.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=bfields@fieldses.org \
    --cc=jlayton@poochiereds.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=teigland@redhat.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.