Re: [PATCH net] r8169: add missing conditional compiling for call to r8169_remove_leds

From: Venkat Rao Bagalkote <venkat88@linux.vnet.ibm.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
	Realtek linux nic maintainers <nic_swsd@realtek.com>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
	David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] r8169: add missing conditional compiling for call to r8169_remove_leds
Date: Thu, 11 Apr 2024 00:09:15 +0530	[thread overview]
Message-ID: <f3804927-5a66-4469-9b12-b11790db30c1@linux.vnet.ibm.com> (raw)
In-Reply-To: <d080038c-eb6b-45ac-9237-b8c1cdd7870f@gmail.com>

Applied the patch and verified the reported issue.

Kernel compilation is successful on PowerPC with this patch.

Tested-By: Venkat Rao Bagalkote <venkat88@linux.vnet.ibm.com>

On 10/04/24 6:41 pm, Heiner Kallweit wrote:
> Add missing dependency on CONFIG_R8169_LEDS. As-is a link error occurs
> if config option CONFIG_R8169_LEDS isn't enabled.
>
> Fixes: 19fa4f2a85d7 ("r8169: fix LED-related deadlock on module removal")
> Reported-by: Venkat Rao Bagalkote <venkat88@linux.vnet.ibm.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>   drivers/net/ethernet/realtek/r8169_main.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 06631a0d6..746ef4f34 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -5046,7 +5046,8 @@ static void rtl_remove_one(struct pci_dev *pdev)
>
>   	cancel_work_sync(&tp->wk.work);
>
> -	r8169_remove_leds(tp->leds);
> +	if (IS_ENABLED(CONFIG_R8169_LEDS))
> +		r8169_remove_leds(tp->leds);
>
>   	unregister_netdev(tp->dev);
>