From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: "jun.miao" <jun.miao@windriver.com>,
jani.nikula@linux.intel.com, daniel@ffwll.ch, airlied@linux.ie
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH][V2] drm/i915/gt: Fix a lockdep warning on RT kernel
Date: Mon, 19 Apr 2021 09:57:37 +0100 [thread overview]
Message-ID: <f3bcef8e-4c02-b019-c3da-5d0ce95af1ac@linux.intel.com> (raw)
In-Reply-To: <1606bffe-f8c9-b619-9647-483393f87105@windriver.com>
On 15/04/2021 13:41, jun.miao wrote:
>
> On 4/15/21 7:12 PM, Tvrtko Ursulin wrote:
>> [Please note: This e-mail is from an EXTERNAL e-mail address]
>>
>> Hi,
>>
>> On 14/04/2021 15:48, Jun Miao wrote:
>>> Don`t simple disable all the HD-irq, should race the region in the
>>> intel_breadcrumbs_disarm_irq() only.
>>>
>>
>> What is HD-irq, I am, not familiar with that term?
>
> Disable local interrupt delivery from Hardware of cpu.:-)
HW then, not HD. ;)
[...]
>>> static void add_signaling_context(struct intel_breadcrumbs *b,
>>> @@ -337,9 +339,7 @@ void __intel_breadcrumbs_park(struct
>>> intel_breadcrumbs *b)
>>> /* Kick the work once more to drain the signalers, and disarm
>>> the irq */
>>> irq_work_sync(&b->irq_work);
>>> while (READ_ONCE(b->irq_armed) && !atomic_read(&b->active)) {
>>> - local_irq_disable();
>>> signal_irq_work(&b->irq_work);
>>> - local_irq_enable();
>>
>> Unfortunately there is another lock inside signal_irq_work (rq->lock)
>> which needs to be taken irq safe.
>>
> Ok, i will change the left spin_lock -> spin_lock_irqsave.
>
> In fact, inside signal_irq_work, intel_breadcrumbs_arm_irq
> (&b->irq_lock) which also needs to be taken irq safe.
>
> Thanks,
>
> Jun
>
>> RT patches are in tree or out of the tree these days?
>
> I base on the mainline kernel tree， and this BUG warning will not
> happen. But RT v5.10 will complain "BUG warning", so i want this patch
> will solve RT WARNING without affecting mainline performance in mainline
> tree.
So the problem is we did not typically do changes to cater for out of
tree stuff, unless they are really minimal. And this one in my view does
not quite qualify as such.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-04-19 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 14:48 [Intel-gfx] [PATCH][V2] drm/i915/gt: Fix a lockdep warning on RT kernel Jun Miao
2021-04-15 9:53 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-04-15 10:21 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-04-15 11:12 ` [Intel-gfx] [PATCH][V2] " Tvrtko Ursulin
2021-04-15 12:41 ` jun.miao
2021-04-19 8:57 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3bcef8e-4c02-b019-c3da-5d0ce95af1ac@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jun.miao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.