Re: [PATCH v6 4/8 rebased] can: replace can_dlc as variable/element for payload length - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH v6 4/8 rebased] can: replace can_dlc as variable/element for payload length
Date: Fri, 20 Nov 2020 11:43:34 +0100	[thread overview]
Message-ID: <f42980b1-d6ad-1e6a-5398-4eb8ca0dd6d5@pengutronix.de> (raw)
In-Reply-To: <20201120100444.3199-1-socketcan@hartkopp.net>

[-- Attachment #1.1: Type: text/plain, Size: 918 bytes --]

On 11/20/20 11:04 AM, Oliver Hartkopp wrote:
> The naming of can_dlc as element of struct can_frame and also as variable
> name is misleading as it claims to be a 'data length CODE' but in reality
> it always was a plain data length.
> 
> With the indroduction of a new 'len' element in struct can_frame we can now
> remove can_dlc as name and make clear which of the former uses was a plain
> length (-> 'len') or a data length code (-> 'dlc') value.
> 
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>

Thanks for the patch, my git rebase successfully worked without problems,
however taking this patch.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]