Re: [PATCH] arm64: dts: qcom: ipq8074: fix the sleep clock frequency

From: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: <agross@kernel.org>, <robh+dt@kernel.org>,
	<varada@codeaurora.org>, <mraghava@codeaurora.org>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
	<quic_srichara@quicinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: ipq8074: fix the sleep clock frequency
Date: Fri, 4 Mar 2022 09:27:59 +0530	[thread overview]
Message-ID: <f4dc04a8-e0b4-d14d-653f-bfaf8f77e79a@quicinc.com> (raw)
In-Reply-To: <848671a3-dcf0-9968-f3fd-a3c5b9902ccf@quicinc.com>

On 2/25/2022 5:48 PM, Kathiravan Thirumoorthy wrote:
>
> On 2/25/2022 1:27 AM, Bjorn Andersson wrote:
>> On Fri 11 Feb 06:14 CST 2022, Kathiravan T wrote:
>>
>>> Sleep clock frequency should be 32768Hz. Lets fix it.
>>>
>>> Cc: stable@vger.kernel.org
>>> Fixes: 41dac73e243d ("arm64: dts: Add ipq8074 SoC and HK01 board 
>>> support")
>>> Link: 
>>> https://lore.kernel.org/all/e2a447f8-6024-0369-f698-2027b6edcf9e@codeaurora.org/
>>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> Can you please confirm this? The documentation for GCC says that the
>> incoming sleep clock is 32000Hz.
>>
>> Regards,
>> Bjorn
>
> Bjorn,
>
> I checked the internal documents and it is derived from the PMIC as 
> 32.7645KHz. I rounded off it to 32768Hz. Looks like GCC documentation 
> is not up-to-date.
>
> All these information is available in the link 
> https://lore.kernel.org/all/e2a447f8-6024-0369-f698-2027b6edcf9e@codeaurora.org/
>
> Please let me know if you need any further information.
>
> Thanks,
>
> Kathiravan T.

Bjorn,

Gentle Ping.

Thanks,

Kathiravan T.

>
>>> ---
>>>   arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi 
>>> b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>>> index 26ba7ce9222c..b6287355ad08 100644
>>> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>>> @@ -13,7 +13,7 @@
>>>       clocks {
>>>           sleep_clk: sleep_clk {
>>>               compatible = "fixed-clock";
>>> -            clock-frequency = <32000>;
>>> +            clock-frequency = <32768>;
>>>               #clock-cells = <0>;
>>>           };
>>>   --
>>> 2.7.4
>>>