From: Kemeng Shi <shikemeng@huaweicloud.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, dwagner@suse.de, hare@suse.de,
ming.lei@redhat.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, john.garry@huawei.com,
jack@suse.cz
Subject: Re: [PATCH v4 07/14] blk-mq: make blk_mq_commit_rqs a general function for all commits
Date: Thu, 19 Jan 2023 09:40:27 +0800 [thread overview]
Message-ID: <f4dea0fc-5fcf-ceec-84d5-468b25c947ff@huaweicloud.com> (raw)
In-Reply-To: <20230118173745.GC12399@lst.de>
on 1/19/2023 1:37 AM, Christoph Hellwig wrote:
> On Wed, Jan 18, 2023 at 05:37:19PM +0800, Kemeng Shi wrote:
>> +/*
>> + * blk_mq_commit_rqs will notify driver using bd->last that there is no
>> + * more requests. (See comment in struct blk_mq_ops for commit_rqs for
>> + * details)
>> + * Attention, we should explicitly call this in unusual cases:
>> + * 1) did not queue everything initially scheduled to queue
>> + * 2) the last attempt to queue a request failed
>> + */
>> +static void blk_mq_commit_rqs(struct blk_mq_hw_ctx *hctx, int queued,
>> + bool from_schedule)
>
> Isn't from_schedule always false here as well now?
Hi Christoph ,
Yes, it's always false now. As blk_mq_commit_rqs is a general function
for all commits now, I keep the from_schedule for commits where
from_schedule maybe true in future. We can remove from_schedule now
and add it back when from_schedule is indeed needed. Both way is
acceptable for me. Please let me know which way do you prefer and I
will send a new version if needed.
Thanks.
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
--
Best wishes
Kemeng Shi
next prev parent reply other threads:[~2023-01-19 1:48 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 9:37 [PATCH v4 01/14] blk-mq: avoid sleep in blk_mq_alloc_request_hctx Kemeng Shi
2023-01-18 9:37 ` [PATCH v4 02/14] blk-mq: remove stale comment for blk_mq_sched_mark_restart_hctx Kemeng Shi
2023-01-18 9:37 ` [PATCH v4 03/14] blk-mq: wait on correct sbitmap_queue in blk_mq_mark_tag_wait Kemeng Shi
2023-01-18 9:37 ` [PATCH v4 04/14] blk-mq: Fix potential io hung for shared sbitmap per tagset Kemeng Shi
2023-02-06 15:52 ` Christoph Hellwig
2023-01-18 9:37 ` [PATCH v4 05/14] blk-mq: remove unnecessary list_empty check in blk_mq_try_issue_list_directly Kemeng Shi
2023-01-18 9:37 ` [PATCH v4 06/14] blk-mq: remove unncessary from_schedule parameter in blk_mq_plug_issue_direct Kemeng Shi
2023-01-18 17:36 ` Christoph Hellwig
2023-02-06 15:52 ` Christoph Hellwig
2023-01-18 9:37 ` [PATCH v4 07/14] blk-mq: make blk_mq_commit_rqs a general function for all commits Kemeng Shi
2023-01-18 17:37 ` Christoph Hellwig
2023-01-19 1:40 ` Kemeng Shi [this message]
2023-01-28 1:55 ` Kemeng Shi
2023-02-06 15:53 ` Christoph Hellwig
2023-01-18 9:37 ` [PATCH v4 08/14] blk-mq: remove unncessary error count and commit in blk_mq_plug_issue_direct Kemeng Shi
2023-01-18 17:38 ` Christoph Hellwig
2023-02-06 15:53 ` Christoph Hellwig
2023-01-18 9:37 ` [PATCH v4 09/14] blk-mq: use blk_mq_commit_rqs helper in blk_mq_try_issue_list_directly Kemeng Shi
2023-01-18 17:38 ` Christoph Hellwig
2023-02-06 15:53 ` Christoph Hellwig
2023-01-18 9:37 ` [PATCH v4 10/14] blk-mq: simplify flush check in blk_mq_dispatch_rq_list Kemeng Shi
2023-01-18 17:38 ` Christoph Hellwig
2023-02-06 15:53 ` Christoph Hellwig
2023-01-18 9:37 ` [PATCH v4 11/14] blk-mq: remove unnecessary error count and " Kemeng Shi
2023-01-18 17:39 ` Christoph Hellwig
2023-02-06 15:54 ` Christoph Hellwig
2023-01-18 9:37 ` [PATCH v4 12/14] blk-mq: remove set of bd->last when get driver tag for next request fails Kemeng Shi
2023-01-18 17:42 ` Christoph Hellwig
2023-01-19 1:45 ` Kemeng Shi
2023-01-28 2:03 ` Kemeng Shi
2023-02-06 1:05 ` Kemeng Shi
2023-02-06 16:06 ` Christoph Hellwig
2023-01-18 9:37 ` [PATCH v4 13/14] blk-mq: use switch/case to improve readability in blk_mq_try_issue_list_directly Kemeng Shi
2023-01-18 17:42 ` Christoph Hellwig
2023-01-18 9:37 ` [PATCH v4 14/14] blk-mq: correct stale comment of .get_budget Kemeng Shi
2023-01-18 17:42 ` Christoph Hellwig
2023-02-06 16:22 ` [PATCH v4 01/14] blk-mq: avoid sleep in blk_mq_alloc_request_hctx Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4dea0fc-5fcf-ceec-84d5-468b25c947ff@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.