All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	Alberto Garcia <berto@igalia.com>,
	qemu-block@nongnu.org, Derek Su <dereksu@qnap.com>,
	Max Reitz <mreitz@redhat.com>
Subject: [PATCH v10 15/34] qcow2: Add qcow2_get_subcluster_range_type()
Date: Fri,  3 Jul 2020 17:58:01 +0200	[thread overview]
Message-ID: <f51ac572c665d14f82a925afe34975172200694b.1593791819.git.berto@igalia.com> (raw)
In-Reply-To: <cover.1593791819.git.berto@igalia.com>

There are situations in which we want to know how many contiguous
subclusters of the same type there are in a given cluster. This can be
done by simply iterating over the subclusters and repeatedly calling
qcow2_get_subcluster_type() for each one of them.

However once we determined the type of a subcluster we can check the
rest efficiently by counting the number of adjacent ones (or zeroes)
in the bitmap. This is what this function does.

Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
 block/qcow2-cluster.c | 51 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 9ba60f3fde..751906c330 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -375,6 +375,57 @@ fail:
     return ret;
 }
 
+/*
+ * For a given L2 entry, count the number of contiguous subclusters of
+ * the same type starting from @sc_from. Compressed clusters are
+ * treated as if they were divided into subclusters of size
+ * s->subcluster_size.
+ *
+ * Return the number of contiguous subclusters and set @type to the
+ * subcluster type.
+ *
+ * If the L2 entry is invalid return -errno and set @type to
+ * QCOW2_SUBCLUSTER_INVALID.
+ */
+G_GNUC_UNUSED
+static int qcow2_get_subcluster_range_type(BlockDriverState *bs,
+                                           uint64_t l2_entry,
+                                           uint64_t l2_bitmap,
+                                           unsigned sc_from,
+                                           QCow2SubclusterType *type)
+{
+    BDRVQcow2State *s = bs->opaque;
+    uint32_t val;
+
+    *type = qcow2_get_subcluster_type(bs, l2_entry, l2_bitmap, sc_from);
+
+    if (*type == QCOW2_SUBCLUSTER_INVALID) {
+        return -EINVAL;
+    } else if (!has_subclusters(s) || *type == QCOW2_SUBCLUSTER_COMPRESSED) {
+        return s->subclusters_per_cluster - sc_from;
+    }
+
+    switch (*type) {
+    case QCOW2_SUBCLUSTER_NORMAL:
+        val = l2_bitmap | QCOW_OFLAG_SUB_ALLOC_RANGE(0, sc_from);
+        return cto32(val) - sc_from;
+
+    case QCOW2_SUBCLUSTER_ZERO_PLAIN:
+    case QCOW2_SUBCLUSTER_ZERO_ALLOC:
+        val = (l2_bitmap | QCOW_OFLAG_SUB_ZERO_RANGE(0, sc_from)) >> 32;
+        return cto32(val) - sc_from;
+
+    case QCOW2_SUBCLUSTER_UNALLOCATED_PLAIN:
+    case QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC:
+        val = ((l2_bitmap >> 32) | l2_bitmap)
+            & ~QCOW_OFLAG_SUB_ALLOC_RANGE(0, sc_from);
+        return ctz32(val) - sc_from;
+
+    default:
+        g_assert_not_reached();
+    }
+}
+
 /*
  * Checks how many clusters in a given L2 slice are contiguous in the image
  * file. As soon as one of the flags in the bitmask stop_flags changes compared
-- 
2.20.1



  parent reply	other threads:[~2020-07-03 16:08 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 15:57 [PATCH v10 00/34] Add subcluster allocation to qcow2 Alberto Garcia
2020-07-03 15:57 ` [PATCH v10 01/34] qcow2: Make Qcow2AioTask store the full host offset Alberto Garcia
2020-07-03 15:57 ` [PATCH v10 02/34] qcow2: Convert qcow2_get_cluster_offset() into qcow2_get_host_offset() Alberto Garcia
2020-07-09 10:13   ` Max Reitz
2020-07-03 15:57 ` [PATCH v10 03/34] qcow2: Add calculate_l2_meta() Alberto Garcia
2020-07-03 15:57 ` [PATCH v10 04/34] qcow2: Split cluster_needs_cow() out of count_cow_clusters() Alberto Garcia
2020-07-03 15:57 ` [PATCH v10 05/34] qcow2: Process QCOW2_CLUSTER_ZERO_ALLOC clusters in handle_copied() Alberto Garcia
2020-07-03 15:57 ` [PATCH v10 06/34] qcow2: Add get_l2_entry() and set_l2_entry() Alberto Garcia
2020-07-03 15:57 ` [PATCH v10 07/34] qcow2: Document the Extended L2 Entries feature Alberto Garcia
2020-07-03 15:57 ` [PATCH v10 08/34] qcow2: Add dummy has_subclusters() function Alberto Garcia
2020-07-03 15:57 ` [PATCH v10 09/34] qcow2: Add subcluster-related fields to BDRVQcow2State Alberto Garcia
2020-07-03 15:57 ` [PATCH v10 10/34] qcow2: Add offset_to_sc_index() Alberto Garcia
2020-07-03 15:57 ` [PATCH v10 11/34] qcow2: Add offset_into_subcluster() and size_to_subclusters() Alberto Garcia
2020-07-03 15:57 ` [PATCH v10 12/34] qcow2: Add l2_entry_size() Alberto Garcia
2020-07-03 15:57 ` [PATCH v10 13/34] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap() Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 14/34] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type() Alberto Garcia
2020-07-03 15:58 ` Alberto Garcia [this message]
2020-07-03 15:58 ` [PATCH v10 16/34] qcow2: Add qcow2_cluster_is_allocated() Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 17/34] qcow2: Add cluster type parameter to qcow2_get_host_offset() Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 18/34] qcow2: Replace QCOW2_CLUSTER_* with QCOW2_SUBCLUSTER_* Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 19/34] qcow2: Handle QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 20/34] qcow2: Add subcluster support to calculate_l2_meta() Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 21/34] qcow2: Add subcluster support to qcow2_get_host_offset() Alberto Garcia
2020-07-09 12:07   ` Max Reitz
2020-07-03 15:58 ` [PATCH v10 22/34] qcow2: Add subcluster support to zero_in_l2_slice() Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 23/34] qcow2: Add subcluster support to discard_in_l2_slice() Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 24/34] qcow2: Add subcluster support to check_refcounts_l2() Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 25/34] qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2() Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 26/34] qcow2: Clear the L2 bitmap when allocating a compressed cluster Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 27/34] qcow2: Add subcluster support to handle_alloc_space() Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 28/34] qcow2: Add subcluster support to qcow2_co_pwrite_zeroes() Alberto Garcia
2020-07-09 12:16   ` Max Reitz
2020-07-03 15:58 ` [PATCH v10 29/34] qcow2: Add subcluster support to qcow2_measure() Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 30/34] qcow2: Add prealloc field to QCowL2Meta Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 31/34] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit Alberto Garcia
2020-07-09 13:07   ` Max Reitz
2020-07-09 13:40     ` Alberto Garcia
2020-07-09 14:04   ` Max Reitz
2020-07-03 15:58 ` [PATCH v10 32/34] qcow2: Allow preallocation and backing files if extended_l2 is set Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 33/34] qcow2: Assert that expand_zero_clusters_in_l1() does not support subclusters Alberto Garcia
2020-07-03 15:58 ` [PATCH v10 34/34] iotests: Add tests for qcow2 images with extended L2 entries Alberto Garcia
2020-07-09 13:21   ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f51ac572c665d14f82a925afe34975172200694b.1593791819.git.berto@igalia.com \
    --to=berto@igalia.com \
    --cc=dereksu@qnap.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.