From: Hans de Goede <hdegoede@redhat.com>
To: Arnd Bergmann <arnd@kernel.org>,
Mark Gross <markgross@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Tim Crawford <tcrawford@system76.com>,
Jeremy Soller <jeremy@system76.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kate Hsuan <hpa@redhat.com>,
"David E. Box" <david.e.box@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Maximilian Luz <luzmaximilian@gmail.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] platform/x86: system76_acpi: fix Kconfig dependencies
Date: Sun, 24 Oct 2021 10:19:40 +0200 [thread overview]
Message-ID: <f52acae3-42b8-72e5-84dd-68eb41ff0efa@redhat.com> (raw)
In-Reply-To: <20211022154901.904984-1-arnd@kernel.org>
Hi,
On 10/22/21 17:48, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_INPUT is disabled, this driver now fails to link:
>
> ld.lld: error: undefined symbol: devm_input_allocate_device
>>>> referenced by system76_acpi.c
>>>> platform/x86/system76_acpi.o:(system76_add) in archive drivers/built-in.a
>
> ld.lld: error: undefined symbol: input_set_capability
>>>> referenced by system76_acpi.c
>>>> platform/x86/system76_acpi.o:(system76_add) in archive drivers/built-in.a
>
> ld.lld: error: undefined symbol: devm_hwmon_device_register_with_info
>>>> referenced by system76_acpi.c
>>>> platform/x86/system76_acpi.o:(system76_add) in archive drivers/built-in.a
>
> ld.lld: error: undefined symbol: battery_hook_unregister
>>>> referenced by system76_acpi.c
>>>> platform/x86/system76_acpi.o:(system76_remove) in archive drivers/built-in.a
>
> Add Kconfig dependencies for each of these three.
>
> Fixes: 0de30fc684b3 ("platform/x86: system76_acpi: Replace Fn+F2 function for OLED models")
> Fixes: 95563d45b5da ("platform/x86: system76_acpi: Report temperature and fan speed")
> Fixes: 76f7eba3e0a2 ("platform/x86: system76_acpi: Add battery charging thresholds")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 56bcf80da60a..c422ee785c56 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -923,6 +923,9 @@ config SONYPI_COMPAT
> config SYSTEM76_ACPI
> tristate "System76 ACPI Driver"
> depends on ACPI
> + depends on ACPI_BATTERY
> + depends on HWMON
> + depends on INPUT
> select NEW_LEDS
> select LEDS_CLASS
> select LEDS_TRIGGERS
>
prev parent reply other threads:[~2021-10-24 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 15:48 [PATCH] platform/x86: system76_acpi: fix Kconfig dependencies Arnd Bergmann
2021-10-22 16:02 ` Andy Shevchenko
2021-10-24 8:19 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f52acae3-42b8-72e5-84dd-68eb41ff0efa@redhat.com \
--to=hdegoede@redhat.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=david.e.box@linux.intel.com \
--cc=hpa@redhat.com \
--cc=jdelvare@suse.com \
--cc=jeremy@system76.com \
--cc=linus.walleij@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luzmaximilian@gmail.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tcrawford@system76.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.