Re: [PATCH v2] target/ppc: code motion from translate_init.c.inc to gdbstub.c

From: Richard Henderson <richard.henderson@linaro.org>
To: "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br>,
	qemu-devel@nongnu.org
Cc: farosas@linux.ibm.com, lucas.araujo@eldorado.org.br,
	luis.pires@eldorado.org.br, fernando.valle@eldorado.org.br,
	matheus.ferst@eldorado.org.br, david@gibson.dropbear.id.au
Subject: Re: [PATCH v2] target/ppc: code motion from translate_init.c.inc to gdbstub.c
Date: Tue, 13 Apr 2021 08:53:15 -0700	[thread overview]
Message-ID: <f580510c-0468-f1bd-5d3a-dc52043e5c1a@linaro.org> (raw)
In-Reply-To: <20210413145427.41749-1-bruno.larsen@eldorado.org.br>

On 4/13/21 7:54 AM, Bruno Larsen (billionai) wrote:
> +/* gdbstub.c */
> +void ppc_gdb_init(CPUState *cs, PowerPCCPUClass *ppc);
> +gchar *ppc_gdb_arch_name(CPUState *cs);

These should probably go into internal.h and not cpu.h.
These do not need to be exposed outside of target/ppc/.

> +#include "exec/helper-proto.h"

Not ideal, but ok temporarily.

> +        gdb_get_reg32(buf, helper_mfvscr(env));
...
> +        helper_mtvscr(env, ldl_p(mem_buf));

These should be modeled on e.g. store_fpscr, where there's a non-"helper" 
function to be called, which is then called by the "helper" function.

Obviously, splitting that out should be a separate patch.

r~