From: Eric Sandeen <sandeen@redhat.com>
To: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 4/4] xfsprogs: don't use enum for buffer flags
Date: Tue, 16 Jul 2019 08:30:49 -0500 [thread overview]
Message-ID: <f5b0d9da-ac2b-4337-4462-4cb4e6d1fab3@redhat.com> (raw)
In-Reply-To: <20190716113805.jx4nch3aclzwjrrc@pegasus.maiolino.io>
On 7/16/19 6:38 AM, Carlos Maiolino wrote:
>> +typedef unsigned int xfs_buf_flags_t;
> I'd argue about the need of hiding an unsigned int into a typedef, which IMHO
> doesn't look necessary here, but I also don't see why not if your main reason is
> try to care about your sanity and bring xfsprogs code closer to kernel, other
> than that, the patch is fine and you can add my review tag with or without the
> typedef.
>
> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
>
> Cheers
>
The point is to match the kernel code, warts and all.
thanks,
-Eric
prev parent reply other threads:[~2019-07-16 13:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 21:31 [PATCH 0/4] xfsprogs: inch libxfs/trans.c towards xfs_trans_buf.c Eric Sandeen
2019-07-12 21:34 ` [PATCH 1/4] xfsprogs: reorder functions in libxfs/trans.c Eric Sandeen
2019-07-16 11:30 ` Carlos Maiolino
2019-07-12 21:36 ` [PATCH 2/4] xfsprogs: cosmetic changes to libxfs/trans.c Eric Sandeen
2019-07-16 11:31 ` Carlos Maiolino
2019-07-12 21:38 ` [PATCH 3/4] xfsprogs: trivial " Eric Sandeen
2019-07-16 11:31 ` Carlos Maiolino
2019-07-12 21:46 ` [PATCH 4/4] xfsprogs: don't use enum for buffer flags Eric Sandeen
2019-07-16 11:38 ` Carlos Maiolino
2019-07-16 13:30 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5b0d9da-ac2b-4337-4462-4cb4e6d1fab3@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.