From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 0/2] file-posix: Cache next hole
Date: Mon, 29 Mar 2021 18:21:37 +0200 [thread overview]
Message-ID: <f5c18995-3e77-ce4a-3c2b-e20978ed0c44@redhat.com> (raw)
In-Reply-To: <20210211172242.146671-1-mreitz@redhat.com>
On 11.02.21 18:22, Max Reitz wrote:
> Hi,
[...]
> (Speaking of “unless the WRITE permission is shared”: mirror_top is a
> bit broken in that it takes no permissions (but WRITE if necessary) and
> shares everything. That seems wrong. Patch 1 addresses that, so that
> patch 2 can actually do something when mirroring an image.)
I plan to send a v2 of patch 2 at some point, but for now I’ve applied
patch 1 to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
https://bugzilla.redhat.com/show_bug.cgi?id=1940118 reports an abort,
which I think can be avoided with patch 1 of this series: The mirror job
lifts all permissions on the source node, so you can freely take locks
with some other process, and then mirror_exit_common() fails when it
tries to take those permissions back (at least when cancelling the job).
I plan to send an iotest for this, but getting this into rc1 is more
important than waiting for the test, I think.
Max
prev parent reply other threads:[~2021-03-29 16:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 17:22 [PATCH 0/2] file-posix: Cache next hole Max Reitz
2021-02-11 17:22 ` [PATCH 1/2] block/mirror: Fix mirror_top's permissions Max Reitz
2021-02-11 19:33 ` Eric Blake
2021-02-12 9:04 ` Vladimir Sementsov-Ogievskiy
2021-02-12 9:23 ` Max Reitz
2021-02-12 10:48 ` Vladimir Sementsov-Ogievskiy
2021-02-11 17:22 ` [PATCH 2/2] file-posix: Cache next hole Max Reitz
2021-02-11 20:00 ` Eric Blake
2021-02-12 9:25 ` Max Reitz
2021-02-11 20:38 ` Vladimir Sementsov-Ogievskiy
2021-02-12 9:14 ` Max Reitz
2021-02-12 10:25 ` Kevin Wolf
2021-02-12 12:11 ` Max Reitz
2021-03-29 16:21 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5c18995-3e77-ce4a-3c2b-e20978ed0c44@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.