Re: [PATCH 0/5] hw/i386/pc: Extract pc_gsi_create() and pc_i8259_create() - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>,
	Sergio Lopez <slp@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 0/5] hw/i386/pc: Extract pc_gsi_create() and pc_i8259_create()
Date: Sat, 26 Oct 2019 16:55:37 +0200	[thread overview]
Message-ID: <f5d9b8c9-302e-336d-5737-3fe421d793a1@redhat.com> (raw)
In-Reply-To: <aac6bd30-317b-d8a2-6442-6f3d37941785@redhat.com>

Hi Paolo,

On 10/22/19 7:32 PM, Philippe Mathieu-Daudé wrote:
> On 10/22/19 6:55 PM, Paolo Bonzini wrote:
>> On 18/10/19 15:59, Philippe Mathieu-Daudé wrote:
>>> These are few patches extracted from the previous too big series:
>>> hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge
>>> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg03685.html
>>>
>>> Dropped "Move kvm_i8259_init() declaration to sysemu/kvm.h" (thuth),
>>> no logical changes:
>>
>> I queued this, but neither I nor patchew got patch 5.  I just got it
>> from the PIIX3/i440FX series.

In the patch 'hw/i386: Introduce the microvm machine type'
Sergio uses gsi_handler(), so you need to drop 'hw/i386/pc:
Reduce gsi_handler scope' to keep microvm building.

> Odd... Yes this is the same patch resent with no change. Thanks for
> noticing this and carrying about finding it!
> 
>>
>> paolo
>>
>>> $ git backport-diff -u pc_split_i440fx_piix-v1
>>> Key:
>>> [----] : patches are identical
>>> [####] : number of functional differences between upstream/downstream 
>>> patch
>>> [down] : patch is downstream-only
>>> The flags [FC] indicate (F)unctional and (C)ontextual differences, 
>>> respectively
>>>
>>> 001/5:[----] [-C] 'hw/i386/pc: Extract pc_gsi_create()'
>>> 002/5:[----] [--] 'hw/i386/pc: Reduce gsi_handler scope'
>>> 003/5:[----] [--] 'hw/i386/pc: Move gsi_state creation code'
>>> 004/5:[----] [--] 'hw/i386/pc: Extract pc_i8259_create()'
>>> 005/5:[----] [--] 'hw/i386/pc: Remove kvm_i386.h include'
>>>
>>> Based-on: <20191018134754.16362-1-philmd@redhat.com>
>>> hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge [v2]
>>> https://mid.mail-archive.com/20191018134754.16362-1-philmd@redhat.com
>>>
>>> Philippe Mathieu-Daudé (5):
>>>    hw/i386/pc: Extract pc_gsi_create()
>>>    hw/i386/pc: Reduce gsi_handler scope
>>>    hw/i386/pc: Move gsi_state creation code
>>>    hw/i386/pc: Extract pc_i8259_create()
>>>    hw/i386/pc: Remove kvm_i386.h include
>>>
>>>   hw/i386/pc.c         | 36 +++++++++++++++++++++++++++++++++++-
>>>   hw/i386/pc_piix.c    | 23 ++---------------------
>>>   hw/i386/pc_q35.c     | 28 ++++------------------------
>>>   include/hw/i386/pc.h |  3 ++-
>>>   4 files changed, 43 insertions(+), 47 deletions(-)
>>>
>>