From: Yonghong Song <yhs@fb.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: "Alexei Starovoitov" <ast@kernel.org>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>,
"Andrii Nakryiko" <andriin@fb.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Maciej Żenczykowski" <maze@google.com>,
"John Stultz" <john.stultz@linaro.org>,
"Alexander Potapenko" <glider@google.com>,
"Alistair Delva" <adelva@google.com>
Subject: Re: [PATCH] bpf: explicitly memset some bpf info structures declared on the stack
Date: Fri, 20 Mar 2020 11:34:11 -0700 [thread overview]
Message-ID: <f7063856-8d52-8e29-9593-cdfa0d26799b@fb.com> (raw)
In-Reply-To: <20200320162258.GA794295@kroah.com>
On 3/20/20 9:22 AM, Greg Kroah-Hartman wrote:
> Trying to initialize a structure with "= {};" will not always clean out
> all padding locations in a structure. So be explicit and call memset to
> initialize everything for a number of bpf information structures that
> are then copied from userspace, sometimes from smaller memory locations
> than the size of the structure.
>
> Reported-by: Daniel Borkmann <daniel@iogearbox.net
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Yonghong Song <yhs@fb.com>
next prev parent reply other threads:[~2020-03-20 18:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 9:48 [PATCH] bpf: explicitly memset the bpf_attr structure Greg Kroah-Hartman
2020-03-20 15:23 ` Yonghong Song
2020-03-20 15:46 ` Greg Kroah-Hartman
2020-03-20 15:24 ` Daniel Borkmann
2020-03-20 15:31 ` Yonghong Song
2020-03-20 15:45 ` Greg Kroah-Hartman
2020-03-20 16:04 ` Daniel Borkmann
2020-03-20 16:15 ` Greg Kroah-Hartman
2020-03-20 16:22 ` [PATCH] bpf: explicitly memset some bpf info structures declared on the stack Greg Kroah-Hartman
2020-03-20 18:34 ` Yonghong Song [this message]
2020-03-20 20:07 ` Daniel Borkmann
2020-03-20 17:59 ` [PATCH] bpf: explicitly memset the bpf_attr structure Sasha Levin
2020-03-20 20:07 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7063856-8d52-8e29-9593-cdfa0d26799b@fb.com \
--to=yhs@fb.com \
--cc=adelva@google.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.