Re: [PATCH] at86rf230: convert to gpio descriptors

From: "Arnd Bergmann" <arnd@arndb.de>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Arnd Bergmann" <arnd@kernel.org>
Cc: "Alexander Aring" <alex.aring@gmail.com>,
	"Stefan Schmidt" <stefan@datenfreihafen.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-wpan@vger.kernel.org, Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] at86rf230: convert to gpio descriptors
Date: Thu, 26 Jan 2023 15:39:45 +0100	[thread overview]
Message-ID: <f83ae34a-b46a-47c8-817a-d82d43178eba@app.fastmail.com> (raw)
In-Reply-To: <20230126151243.3acc1fe2@xps-13>

On Thu, Jan 26, 2023, at 15:12, Miquel Raynal wrote:

>> @@ -1682,7 +1650,7 @@ MODULE_DEVICE_TABLE(spi, at86rf230_device_id);
>>  static struct spi_driver at86rf230_driver = {
>>  	.id_table = at86rf230_device_id,
>>  	.driver = {
>> -		.of_match_table = of_match_ptr(at86rf230_of_match),
>> +		.of_match_table = at86rf230_of_match,
>
> Looks like an unrelated change? Or is it a consequence of "not having
> any in-tree users of platform_data" that plays a role here?

I probably did it because I thought I had removed the matching #ifdef
for at86rf230_of_match in the process of making the driver DT-only.

Without this trivial change, building the driver as built-in with
CONFIG_OF=n can result in a warning like

drivers/net/ieee802154/at86rf230.c:1632:28: error: unused variable 'at86rf230_of_match' [-Werror,-Wunused-variable]

It looks like this was already removed in a8b66db804f0 ("at86rf230:
remove #ifdef CONFIG_OF"), which was not technically correct, but
nobody noticed, including me.

I could split this out as a separate patch, but it's probably
not worth it.

> Anyhow, the changes in the driver look good, so:
>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,

    Arnd