From: Jan Beulich <jbeulich@suse.com>
To: Paul Durrant <pdurrant@amazon.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: "Kevin Tian" <kevin.tian@intel.com>, "Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Julien Grall" <jgrall@amazon.com>,
"Jun Nakajima" <jun.nakajima@intel.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2] xen/x86: vpmu: Unmap per-vCPU PMU page when the domain is destroyed
Date: Wed, 27 Nov 2019 16:44:37 +0100 [thread overview]
Message-ID: <f847a83d-ce95-5fd4-3cdd-d74f45dcadd6@suse.com> (raw)
In-Reply-To: <20191127120046.1246-1-pdurrant@amazon.com>
On 27.11.2019 13:00, Paul Durrant wrote:
> --- a/xen/arch/x86/cpu/vpmu.c
> +++ b/xen/arch/x86/cpu/vpmu.c
> @@ -479,6 +479,8 @@ static int vpmu_arch_initialise(struct vcpu *v)
>
> if ( ret )
> printk(XENLOG_G_WARNING "VPMU: Initialization failed for %pv\n", v);
> + else
> + vpmu_set(vpmu, VPMU_CONTEXT_ALLOCATED);
>
> return ret;
> }
> @@ -576,11 +578,36 @@ static void vpmu_arch_destroy(struct vcpu *v)
>
> vpmu->arch_vpmu_ops->arch_vpmu_destroy(v);
> }
> +
> + vpmu_reset(vpmu, VPMU_CONTEXT_ALLOCATED);
> }
Boris,
I'd like to ask that you comment on this part of the change at
least, as I seem to vaguely recall that things were intentionally
not done this way originally.
Paul,
everything else looks god to me now.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-11-27 15:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 12:00 [Xen-devel] [PATCH v2] xen/x86: vpmu: Unmap per-vCPU PMU page when the domain is destroyed Paul Durrant
2019-11-27 15:44 ` Jan Beulich [this message]
2019-11-27 16:32 ` Boris Ostrovsky
2019-11-27 16:46 ` Durrant, Paul
2019-11-27 19:41 ` Julien Grall
2019-11-28 9:13 ` Durrant, Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f847a83d-ce95-5fd4-3cdd-d74f45dcadd6@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgrall@amazon.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=pdurrant@amazon.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.