From: Heming Zhao <heming.zhao@suse.com>
To: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: ocfs2-devel@lists.linux.dev, ailiop@suse.com
Subject: Re: [PATCH v4 3/3] ocfs2: speed up chain-list searching
Date: Wed, 27 Mar 2024 20:59:45 +0800 [thread overview]
Message-ID: <f8488499-341d-437a-a28a-799d994d1460@suse.com> (raw)
In-Reply-To: <d9ab276e-5d68-4759-8d15-3a94bd9ff4ab@linux.alibaba.com>
On 3/27/24 19:17, Joseph Qi wrote:
>
>
> On 3/27/24 4:21 PM, Heming Zhao wrote:
>> ocfs2_claim_suballoc_bits():
>> - Add short-circuit code to speed up searching
>>
>> ocfs2_local_alloc_new_window():
>> - remove 1 sparse warning
>> ```
>> fs/ocfs2/localalloc.c:1224:41: warning: incorrect type in argument 1 (different base types)
>> fs/ocfs2/localalloc.c:1224:41: expected unsigned long long val1
>> fs/ocfs2/localalloc.c:1224:41: got restricted __le32 [usertype] la_bm_off
>> ```
>
> Could you please split the sparse warning into a separate patch?
> For 'la_bm_off', it seems that other place may also has similar warning,
> e.g. ocfs2_load_local_alloc().
>
> Joseph
No problem.
-Heming
prev parent reply other threads:[~2024-03-27 12:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 8:21 [PATCH v4 0/3] improve write IO performance when fragmentation is high Heming Zhao
2024-03-27 8:21 ` [PATCH v4 1/3] ocfs2: " Heming Zhao
2024-03-27 10:58 ` Joseph Qi
2024-03-27 12:54 ` Heming Zhao
2024-03-28 1:50 ` Joseph Qi
2024-03-28 1:55 ` Heming Zhao
2024-03-27 8:21 ` [PATCH v4 2/3] ocfs2: adjust enabling place for la window Heming Zhao
2024-03-27 11:05 ` Joseph Qi
2024-03-27 12:59 ` Heming Zhao
2024-03-28 1:58 ` Joseph Qi
2024-03-28 2:36 ` Heming Zhao
2024-03-27 8:21 ` [PATCH v4 3/3] ocfs2: speed up chain-list searching Heming Zhao
2024-03-27 11:17 ` Joseph Qi
2024-03-27 12:59 ` Heming Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8488499-341d-437a-a28a-799d994d1460@suse.com \
--to=heming.zhao@suse.com \
--cc=ailiop@suse.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.