From: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
To: Qu Wenruo <wqu@suse.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 0/2] btrfs-progs: completion: Small fixes to make debug simpler
Date: Tue, 31 Jul 2018 10:47:32 +0900 [thread overview]
Message-ID: <f8bc239c-3884-7f61-51d0-3b2b83806d67@jp.fujitsu.com> (raw)
In-Reply-To: <20180717061532.11857-1-wqu@suse.com>
This is useful.
Reviewed-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
On 2018/07/17 15:15, Qu Wenruo wrote:
> For developer, it's pretty common to use "btrfs check" or "btrfs ins
> dump-tree" on raw dumps.
>
> However "btrfs check" can only complete real block devices, and
> "btrfs inspect dump-tree" can only complete dir.
>
> Make them to use _filedir() so any filename can be completed and save us
> developer a little time and nerve hitting that holy tab.
>
> Qu Wenruo (2):
> btrfs-progs: completion: Use _filedir() to replace _btrfs_devs()
> btrfs-progs: completion: Let dump-tree/dump-super/inode-resolve to
> accept any file
>
> btrfs-completion | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
prev parent reply other threads:[~2018-07-31 3:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 6:15 [PATCH 0/2] btrfs-progs: completion: Small fixes to make debug simpler Qu Wenruo
2018-07-17 6:15 ` [PATCH 1/2] btrfs-progs: completion: Use _filedir() to replace _btrfs_devs() Qu Wenruo
2018-08-03 14:00 ` David Sterba
2018-08-03 14:04 ` Qu Wenruo
2018-07-17 6:15 ` [PATCH 2/2] btrfs-progs: completion: Let dump-tree/dump-super/inode-resolve to accept any file Qu Wenruo
2018-07-31 1:47 ` Misono Tomohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8bc239c-3884-7f61-51d0-3b2b83806d67@jp.fujitsu.com \
--to=misono.tomohiro@jp.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.