From: Thorsten Leemhuis <linux@leemhuis.info>
To: Jeffery Miller <jefferymiller@google.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: regressions@lists.linux.dev, benjamin.tissoires@redhat.com,
Andrew Duggan <aduggan@synaptics.com>,
Andrew Duggan <andrew@duggan.us>,
loic.poulain@linaro.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: elantech - fix fast_reconnect callback in ps2 mode
Date: Wed, 4 Oct 2023 07:07:38 +0200 [thread overview]
Message-ID: <f8ce2911-e6f2-4423-9ace-262432ec19ad@leemhuis.info> (raw)
In-Reply-To: <20231004005729.3943515-1-jefferymiller@google.com>
On 04.10.23 02:57, Jeffery Miller wrote:
> Make `elantech_setup_ps2` set a compatible fast_reconnect pointer
> when its ps2 mode is used.
>
> When an SMBus connection is attempted and fails `psmouse_smbus_init`
> sets fast_reconnect to `psmouse_smbus_reconnect`.
> `psmouse_smbus_reconnect` expects `psmouse->private` to be
> `struct psmouse_smbus_dev` but `elantech_setup_ps2` replaces
> it with its private data. This was causing an issue on resume
> since psmouse_smbus_reconnect was being called while in ps2, not SMBus
> mode.
>
> This was uncovered by commit 92e24e0e57f7 ("Input: psmouse - add delay when
> deactivating for SMBus mode")
Ahh, thx for investigating. This fixes things for me. Feel free to add:
Tested-by: Thorsten Leemhuis <linux@leemhuis.info>
> Closes:
> Link:https://lore.kernel.org/all/ca0109fa-c64b-43c1-a651-75b294d750a1@leemhuis.info/
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
Side note: something went sideways here, it afaics should look something
like this:
"""
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Closes:
https://lore.kernel.org/all/ca0109fa-c64b-43c1-a651-75b294d750a1@leemhuis.info/
"""
Thx again. Ciao, Thorsten
next prev parent reply other threads:[~2023-10-04 5:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 0:57 [PATCH] Input: elantech - fix fast_reconnect callback in ps2 mode Jeffery Miller
2023-10-04 5:07 ` Thorsten Leemhuis [this message]
2023-10-04 6:19 ` Greg Kroah-Hartman
2023-10-04 6:34 ` Thorsten Leemhuis
2023-10-05 0:35 ` Jeffery Miller
2023-10-04 14:10 ` Dmitry Torokhov
2023-10-05 0:13 ` Jeffery Miller
2023-10-10 7:08 ` Thorsten Leemhuis
2023-10-12 22:53 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8ce2911-e6f2-4423-9ace-262432ec19ad@leemhuis.info \
--to=linux@leemhuis.info \
--cc=aduggan@synaptics.com \
--cc=andrew@duggan.us \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jefferymiller@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.