Re: [PATCH v5 3/3] Input: xen-kbdfront - allow better run-time configuration

From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, jgross@suse.com, lyan@suse.com,
	boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
	andrii_chepurnyi@epam.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v5 3/3] Input: xen-kbdfront - allow better run-time configuration
Date: Wed, 13 Jun 2018 08:47:17 +0300	[thread overview]
Message-ID: <f9354bee-3e44-eb93-05bc-58b8a9078b72@gmail.com> (raw)
In-Reply-To: <20180612220722.GA38773@dtor-ws>

On 06/13/2018 01:07 AM, Dmitry Torokhov wrote:
> On Tue, Jun 12, 2018 at 10:48:56AM +0300, Oleksandr Andrushchenko wrote:
>>   
>> +	if (!(with_kbd | with_ptr | with_mtouch)) {
> I changed this to logical "OR" and applied, thank you.
Yes, that's better, thank you
>> +		ret = -ENXIO;
>> +		goto error;
>> +	}
>> +
>>   	ret = xenkbd_connect_backend(dev, info);
>>   	if (ret < 0)
>>   		goto error;
>> -- 
>> 2.17.1
>>