Re: [PATCH v2 03/16] hwmon: (mr75203) update Moortec PVT controller intel, vm-map property

From: "Farber, Eliav" <farbere@amazon.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: <jdelvare@suse.com>, <robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <talel@amazon.com>,
	<hhhawa@amazon.com>, <jonnyc@amazon.com>, <hanochu@amazon.com>,
	<ronenk@amazon.com>, <itamark@amazon.com>, <shellykz@amazon.com>,
	<shorer@amazon.com>, <amitlavi@amazon.com>, <almogbs@amazon.com>,
	<dwmw@amazon.co.uk>, <rtanwar@maxlinear.com>
Subject: Re: [PATCH v2 03/16] hwmon: (mr75203) update Moortec PVT controller intel, vm-map property
Date: Thu, 18 Aug 2022 23:20:22 +0300	[thread overview]
Message-ID: <f9455757-9b7c-683f-2347-118d997968a1@amazon.com> (raw)
In-Reply-To: <20220818194735.GA3279179@roeck-us.net>

On 8/18/2022 10:47 PM, Guenter Roeck wrote:
> Ah. This patch should come first, before making associated
> code changes, and there would need to be an explanation
> _why_ it is not a mandatory property. Also, some action
> is taken in the previous patches if the property is not
> there. That indicates that the driver is expected to
> use some defaults if the property is indeed not provided,
> and that expected default should be documented. 
Ack.
I should have been more clear and explained that driver actually handles
the case that "intel,vm-map" does not exist (including an explicit comment
- "Incase intel,vm-map property is not defined ...") and that it is
actually optional.

--
Regards, Eliav