Re: [PATCH 00/10] Improve crc-core driver interface

From: "Kumar, Mahesh" <mahesh1.kumar@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 00/10] Improve crc-core driver interface
Date: Tue, 26 Jun 2018 12:02:05 +0530	[thread overview]
Message-ID: <f94a38c0-b731-0a2c-5224-8af67811d6cf@intel.com> (raw)
In-Reply-To: <20180626062259.15563-1-mahesh1.kumar@intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 2294 bytes --]

Cc:dri-devel@lists.freedesktop.org


On 6/26/2018 11:52 AM, Mahesh Kumar wrote:
> This series improves crc-core <-> driver interface.
> This series adds following functionality in the crc-core
>   - Now control node will print all the available sources if
>     implemented by driver along with current source.
>   - Setting of sorce will fail if provided source is not supported
>   - cleanup of crtc_crc_open function first allocate memory before
>     enabling CRC generation
>   - Don't block open() call instead wait in crc read call.
>
> Following IGT will fail due to crc-core <-> driver interface change
> igt@kms_pipe_crc_basic@bad-source <now setting bad-source itself will fail>
> ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X
> ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence
> In nonblocking crc tests we'll get lesser crc's due to skipping crc
>
> AMD/Rockchip/rcar code path is not validated and need inputs
>
> Changes:
>   - Add dri-devel in Cc
>
> Mahesh Kumar (10):
>    drm: crc: Introduce verify_crc_source callback
>    drm: crc: Introduce pre_crc_read function
>    drm: crc: Introduce get_crc_sources callback
>    drm/rockchip/crc: Implement verify_crc_source callback
>    drm/amdgpu_dm/crc: Implement verify_crc_source callback
>    drm/rcar-du/crc: Implement verify_crc_source callback
>    drm/i915/crc: implement verify_crc_source callback
>    drm/i915/crc: implement get_crc_sources callback
>    drm/crc: Cleanup crtc_crc_open function
>    Revert "drm: crc: Wait for a frame before returning from open()"
>
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c  |   1 +
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h  |   7 +-
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c  |  20 +++-
>   drivers/gpu/drm/drm_debugfs_crc.c                  |  62 ++++++-----
>   drivers/gpu/drm/i915/intel_display.c               |   2 +
>   drivers/gpu/drm/i915/intel_drv.h                   |   8 +-
>   drivers/gpu/drm/i915/intel_pipe_crc.c              | 124 ++++++++++++++++++++-
>   drivers/gpu/drm/rcar-du/rcar_du_crtc.c             |  45 +++++++-
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c        |  27 ++++-
>   include/drm/drm_crtc.h                             |  42 ++++++-
>   10 files changed, 288 insertions(+), 50 deletions(-)
>


[-- Attachment #1.2: Type: text/html, Size: 2677 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel