Re: [PATCH 3/5] tests: increase migration test converge downtime to 30 seconds

From: Laurent Vivier <lvivier@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	 Thomas Huth <thuth@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	qemu-s390x@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 3/5] tests: increase migration test converge downtime to 30 seconds
Date: Tue, 28 Jun 2022 14:47:41 +0200	[thread overview]
Message-ID: <f968139f-5c07-8852-96e1-8a0b62e2b877@redhat.com> (raw)
In-Reply-To: <20220628105434.295905-4-berrange@redhat.com>

On 28/06/2022 12:54, Daniel P. Berrangé wrote:
> While 1 second might be enough to converge migration on a fast host,
> this is not guaranteed, especially if using TLS in the tests without
> hardware accelerated crypto available.
> 
> Increasing the downtime to 30 seconds should guarantee it can converge
> in any sane scenario.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/qtest/migration-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index ac9e303b1f..a54eff6d56 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -47,7 +47,7 @@ unsigned end_address;
>   static bool uffd_feature_thread_id;
>   
>   /* A downtime where the test really should converge */
> -#define CONVERGE_DOWNTIME 1000
> +#define CONVERGE_DOWNTIME (1000 * 30)
>   
>   #if defined(__linux__)
>   #include <sys/syscall.h>

Reviewed-by: Laurent Vivier <laurent@vivier.eu>