From: Andrzej Hajda <a.hajda@samsung.com>
To: Lucas Stach <l.stach@pengutronix.de>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/bridge: tc358767: do a software reset if reset pin isn't connected
Date: Mon, 1 Jul 2019 12:36:27 +0200 [thread overview]
Message-ID: <f974517c-031b-a2b2-ea5c-f98efc87c178@samsung.com> (raw)
In-Reply-To: <20190627085958.28331-1-l.stach@pengutronix.de>
On 27.06.2019 10:59, Lucas Stach wrote:
> To get the chip into the expected state, even when the hardware reset pin
> isn't connected, do a software reset in this case. It isn't as thorough as
> the hardware reset, as the I2C communication block can not be reset for
> obvious reasons, but it's getting the chip into a defined state.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Queued to drm-misc-next.
Regards
Andrzej
> ---
> drivers/gpu/drm/bridge/tc358767.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index 13ade28a36a8..1d5ba451e268 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -70,6 +70,13 @@
> #define DP0_VIDSRC_DSI_RX (1 << 0)
> #define DP0_VIDSRC_DPI_RX (2 << 0)
> #define DP0_VIDSRC_COLOR_BAR (3 << 0)
> +#define SYSRSTENB 0x050c
> +#define ENBI2C (1 << 0)
> +#define ENBLCD0 (1 << 2)
> +#define ENBBM (1 << 3)
> +#define ENBDSIRX (1 << 4)
> +#define ENBREG (1 << 5)
> +#define ENBHDCP (1 << 8)
> #define GPIOM 0x0540
> #define GPIOC 0x0544
> #define GPIOO 0x0548
> @@ -1497,6 +1504,22 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)
>
> tc->assr = (tc->rev == 0x6601); /* Enable ASSR for eDP panels */
>
> + if (!tc->reset_gpio) {
> + /*
> + * If the reset pin isn't present, do a software reset. It isn't
> + * as thorough as the hardware reset, as we can't reset the I2C
> + * communication block for obvious reasons, but it's getting the
> + * chip into a defined state.
> + */
> + regmap_update_bits(tc->regmap, SYSRSTENB,
> + ENBLCD0 | ENBBM | ENBDSIRX | ENBREG | ENBHDCP,
> + 0);
> + regmap_update_bits(tc->regmap, SYSRSTENB,
> + ENBLCD0 | ENBBM | ENBDSIRX | ENBREG | ENBHDCP,
> + ENBLCD0 | ENBBM | ENBDSIRX | ENBREG | ENBHDCP);
> + usleep_range(5000, 10000);
> + }
> +
> if (tc->hpd_pin >= 0) {
> u32 lcnt_reg = tc->hpd_pin == 0 ? INT_GP0_LCNT : INT_GP1_LCNT;
> u32 h_lc = INT_GPIO_H(tc->hpd_pin) | INT_GPIO_LC(tc->hpd_pin);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-07-01 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190627090004epcas2p4a8a3e8272463c5e540b6924fc81b2a9a@epcas2p4.samsung.com>
2019-06-27 8:59 ` [PATCH] drm/bridge: tc358767: do a software reset if reset pin isn't connected Lucas Stach
2019-07-01 10:36 ` Andrzej Hajda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f974517c-031b-a2b2-ea5c-f98efc87c178@samsung.com \
--to=a.hajda@samsung.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrew.smirnov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.