From: Dario Faggioli <dfaggioli@suse.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Wei Liu" <wei.liu2@citrix.com>,
"George Dunlap" <george.dunlap@eu.citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Julien Grall" <julien.grall@arm.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v2 1/6] xen/sched: call cpu_disable_scheduler() via cpu notifier
Date: Fri, 29 Mar 2019 18:19:05 +0100 [thread overview]
Message-ID: <f98e2a7bd40bd3809b382a0adf6b4c53832803a1.camel@suse.com> (raw)
In-Reply-To: <20190328120658.11083-2-jgross@suse.com>
[-- Attachment #1.1: Type: text/plain, Size: 1274 bytes --]
On Thu, 2019-03-28 at 13:06 +0100, Juergen Gross wrote:
> cpu_disable_scheduler() is being called from __cpu_disable() today.
> There is no need to execute it on the cpu just being disabled, so use
> the CPU_DEAD case of the cpu notifier chain. Moving the call out of
> stop_machine() context is fine, as we just need to hold the domain
> RCU
> lock and need the scheduler percpu data to be still allocated.
>
> Add another hook for CPU_DOWN_PREPARE to bail out early in case
> cpu_disable_scheduler() would fail. This will avoid crashes in rare
> cases for cpu hotplug or suspend.
>
> While at it remove a superfluous smp_mb() in the ARM __cpu_disable()
> incarnation.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> V2:
> - add CPU_DOWN_PREPARE hook
> - BUG() in case of cpu_disable_scheduler() failing in CPU_DEAD
> (Jan Beulich)
> - modify ARM __cpu_disable(), too (Andrew Cooper)
> ---
>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
Regards,
Dario
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-03-29 17:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 12:06 [PATCH v2 0/6] xen: simplify suspend/resume handling Juergen Gross
2019-03-28 12:06 ` [PATCH v2 1/6] xen/sched: call cpu_disable_scheduler() via cpu notifier Juergen Gross
2019-03-29 17:19 ` Dario Faggioli [this message]
2019-04-01 10:34 ` Julien Grall
2019-03-28 12:06 ` [PATCH v2 2/6] xen: add helper for calling notifier_call_chain() to common/cpu.c Juergen Gross
2019-03-29 17:33 ` Dario Faggioli
2019-03-28 12:06 ` [PATCH v2 3/6] xen: add new cpu notifier action CPU_RESUME_FAILED Juergen Gross
2019-03-28 12:06 ` [PATCH v2 4/6] xen: don't free percpu areas during suspend Juergen Gross
2019-03-28 13:39 ` Jan Beulich
2019-03-28 12:06 ` [PATCH v2 5/6] xen/cpupool: simplify suspend/resume handling Juergen Gross
2019-03-28 12:06 ` [PATCH v2 6/6] xen/sched: don't disable scheduler on cpus during suspend Juergen Gross
2019-03-29 17:36 ` Dario Faggioli
2019-03-28 13:01 ` [PATCH v2 0/6] xen: simplify suspend/resume handling Volodymyr Babchuk
2019-03-28 13:21 ` Juergen Gross
2019-03-28 13:23 ` Julien Grall
2019-03-28 13:34 ` Volodymyr Babchuk
2019-03-28 13:33 ` Julien Grall
2019-03-28 13:37 ` Juergen Gross
2019-03-28 13:49 ` Julien Grall
2019-03-28 13:56 ` Volodymyr Babchuk
2019-03-28 14:43 ` Julien Grall
2019-03-28 14:53 ` Dario Faggioli
2019-03-28 14:57 ` Volodymyr Babchuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f98e2a7bd40bd3809b382a0adf6b4c53832803a1.camel@suse.com \
--to=dfaggioli@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.