Re: [PATCH v2] hwspinlock: ignore disabled device

From: Fabien DESSENNE <fabien.dessenne@st.com>
To: Ohad Ben-Cohen <ohad@wizery.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	"linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Benjamin GAIGNARD <benjamin.gaignard@st.com>,
	Fabien DESSENNE <fabien.dessenne@st.com>
Subject: Re: [PATCH v2] hwspinlock: ignore disabled device
Date: Mon, 13 May 2019 09:08:32 +0000	[thread overview]
Message-ID: <f9baeb01-5610-8a4c-c355-20beeb6d6ec7@st.com> (raw)
In-Reply-To: <1552064026-11415-1-git-send-email-fabien.dessenne@st.com>

Hi


Gentle reminder


Fabien

On 08/03/2019 5:53 PM, Fabien Dessenne wrote:
> Do not wait for hwspinlock device registration if it is not available
> for use.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---
> V2: use 'goto out' instead of 'return'
>
>   drivers/hwspinlock/hwspinlock_core.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/hwspinlock/hwspinlock_core.c b/drivers/hwspinlock/hwspinlock_core.c
> index 2bad40d..d806307 100644
> --- a/drivers/hwspinlock/hwspinlock_core.c
> +++ b/drivers/hwspinlock/hwspinlock_core.c
> @@ -333,6 +333,11 @@ int of_hwspin_lock_get_id(struct device_node *np, int index)
>   	if (ret)
>   		return ret;
>   
> +	if (!of_device_is_available(args.np)) {
> +		ret = -ENOENT;
> +		goto out;
> +	}
> +
>   	/* Find the hwspinlock device: we need its base_id */
>   	ret = -EPROBE_DEFER;
>   	rcu_read_lock();