Re: [PATCH] fcoe: fix io path allocation

From: Lee Duncan <lduncan@suse.com>
To: Mike Christie <michael.christie@oracle.com>,
	martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	james.bottomley@hansenpartnership.com
Cc: Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] fcoe: fix io path allocation
Date: Fri, 7 Aug 2020 15:41:34 -0700	[thread overview]
Message-ID: <fb218812-e447-f60f-8cda-bfcef6e11bda@suse.com> (raw)
In-Reply-To: <1596831813-9839-1-git-send-email-michael.christie@oracle.com>

On 8/7/20 1:23 PM, Mike Christie wrote:
> ixgbe_fcoe_ddp_setup can be called from the main IO path and is called
> with a spin_lock held, so we have to use GFP_ATOMIC allocation instead
> of GFP_KERNEL.
> 
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> cc: Hannes Reinecke <hare@suse.de>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
> index ec7a11d..9e70b9a 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
> @@ -192,7 +192,7 @@ static int ixgbe_fcoe_ddp_setup(struct net_device *netdev, u16 xid,
>  	}
>  
>  	/* alloc the udl from per cpu ddp pool */
> -	ddp->udl = dma_pool_alloc(ddp_pool->pool, GFP_KERNEL, &ddp->udp);
> +	ddp->udl = dma_pool_alloc(ddp_pool->pool, GFP_ATOMIC, &ddp->udp);
>  	if (!ddp->udl) {
>  		e_err(drv, "failed allocated ddp context\n");
>  		goto out_noddp_unmap;
> 

Reviewed-by: Lee Duncan <lduncan@suse.com>