From: gubbaven@codeaurora.org
To: marcel@holtmann.org, johan.hedberg@gmail.com
Cc: mka@chromium.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, robh@kernel.org,
hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org,
bgodavar@codeaurora.org, tientzu@chromium.org,
seanpaul@chromium.org, rjliao@codeaurora.org, yshavit@google.com
Subject: Re: [PATCH v3] Bluetooth: hci_qca:Removed the function qca_setup_clock()
Date: Mon, 03 Feb 2020 14:59:28 +0530 [thread overview]
Message-ID: <fb372af8420a7af076ffbb5f44542497@codeaurora.org> (raw)
In-Reply-To: <1580717149-7609-1-git-send-email-gubbaven@codeaurora.org>
Please discard this.I will be sending another patch set.
Regards,
Venkata.
On 2020-02-03 13:35, Venkata Lakshmi Narayana Gubba wrote:
> For enabling and disabling clocks, directly called the functions
> clk_prepare_enable() and clk_disable_unprepare() respectively.
>
> Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
> ---
> drivers/bluetooth/hci_qca.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 73706f3..eacc65b 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1738,15 +1738,6 @@ static int qca_power_off(struct hci_dev *hdev)
> return 0;
> }
>
> -static int qca_setup_clock(struct clk *clk, bool enable)
> -{
> - if (enable)
> - return clk_prepare_enable(clk);
> -
> - clk_disable_unprepare(clk);
> - return 0;
> -}
> -
> static int qca_regulator_enable(struct qca_serdev *qcadev)
> {
> struct qca_power *power = qcadev->bt_power;
> @@ -1764,7 +1755,7 @@ static int qca_regulator_enable(struct qca_serdev
> *qcadev)
>
> power->vregs_on = true;
>
> - ret = qca_setup_clock(qcadev->susclk, true);
> + ret = clk_prepare_enable(qcadev->susclk);
> if (ret) {
> /* Turn off regulators to overcome power leakage */
> qca_regulator_disable(qcadev);
> @@ -1791,7 +1782,7 @@ static void qca_regulator_disable(struct
> qca_serdev *qcadev)
> power->vregs_on = false;
>
> if (qcadev->susclk)
> - qca_setup_clock(qcadev->susclk, false);
> + clk_disable_unprepare(qcadev->susclk);
> }
>
> static int qca_init_regulators(struct qca_power *qca,
prev parent reply other threads:[~2020-02-03 9:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 8:05 [PATCH v3] Bluetooth: hci_qca:Removed the function qca_setup_clock() Venkata Lakshmi Narayana Gubba
2020-02-03 9:29 ` gubbaven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb372af8420a7af076ffbb5f44542497@codeaurora.org \
--to=gubbaven@codeaurora.org \
--cc=bgodavar@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=rjliao@codeaurora.org \
--cc=robh@kernel.org \
--cc=seanpaul@chromium.org \
--cc=tientzu@chromium.org \
--cc=yshavit@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.